Skip to content

ops: turn off message relayer#1740

Merged
tynes merged 1 commit intodevelopfrom
ops/no-longer-use-message-relayer
Nov 30, 2021
Merged

ops: turn off message relayer#1740
tynes merged 1 commit intodevelopfrom
ops/no-longer-use-message-relayer

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Nov 10, 2021

Description

Don't bring up the message relayer in the docker-compose setup.
This is a breaking change and will need to be communicated.

Ideally there is time to communicate this but regenesis/0.5.0 is breaking compared to develop, we might as well get this in now. Should save on some CI time

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021

⚠️ No Changeset found

Latest commit: 8012080

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smartcontracts
Copy link
Contributor

I don't think we should merge this. We need time to communicate this properly and it will break developer workflows.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #1740 (465d3bf) into regenesis/0.5.0 (770ceca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           regenesis/0.5.0    #1740   +/-   ##
================================================
  Coverage            72.64%   72.64%           
================================================
  Files                   69       69           
  Lines                 2274     2274           
  Branches               337      337           
================================================
  Hits                  1652     1652           
  Misses                 622      622           
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 57.72% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 83.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 770ceca...465d3bf. Read the comment docs.

Base automatically changed from regenesis/0.5.0 to develop November 10, 2021 22:08
@tynes
Copy link
Contributor Author

tynes commented Nov 30, 2021

When running docker-compose up, the message relayer is broken and does not start. It is unclear how long this has been happening.

$ dc logs -f relayer
ops-relayer-1  | internal/modules/cjs/loader.js:905
ops-relayer-1  |   throw err;
ops-relayer-1  |   ^
ops-relayer-1  |
ops-relayer-1  | Error: Cannot find module '/opt/optimism/packages/message-relayer/exec/run-message-relayer.js'
ops-relayer-1  |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
ops-relayer-1  |     at Function.Module._load (internal/modules/cjs/loader.js:746:27)
ops-relayer-1  |     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
ops-relayer-1  |     at internal/main/run_main_module.js:17:47 {
ops-relayer-1  |   code: 'MODULE_NOT_FOUND',
ops-relayer-1  |   requireStack: []
ops-relayer-1  | }

Therefore it is safe to merge this PR as the message relayer does not even work in its current state. There is nobody using it.

Don't bring up the message relayer in the docker-compose setup.
This is a breaking change and will need to be communicated.
@tynes tynes force-pushed the ops/no-longer-use-message-relayer branch from 465d3bf to 8012080 Compare November 30, 2021 17:53
@tynes tynes merged commit 274f862 into develop Nov 30, 2021
@tynes tynes deleted the ops/no-longer-use-message-relayer branch November 30, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants