Skip to content

regenesis-surgery: enable 1inch deployer tests#1724

Merged
tynes merged 1 commit intoregenesis/0.5.0from
test/1inch-deployer
Nov 9, 2021
Merged

regenesis-surgery: enable 1inch deployer tests#1724
tynes merged 1 commit intoregenesis/0.5.0from
test/1inch-deployer

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Nov 9, 2021

Description
Enables + fixes the tests for the 1inch deployer in the regenesis surgery tests

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2021

⚠️ No Changeset found

Latest commit: 4016d5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #1724 (4016d5a) into regenesis/0.5.0 (8282054) will increase coverage by 8.11%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           regenesis/0.5.0    #1724      +/-   ##
===================================================
+ Coverage            72.64%   80.76%   +8.11%     
===================================================
  Files                   69       47      -22     
  Lines                 2274     1440     -834     
  Branches               337      215     -122     
===================================================
- Hits                  1652     1163     -489     
+ Misses                 622      277     -345     
Flag Coverage Δ
batch-submitter ?
contracts 87.96% <ø> (ø)
core-utils 57.72% <ø> (ø)
data-transport-layer ?
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/data-transport-layer/src/utils/constants.ts
...kages/batch-submitter/src/batch-submitter/index.ts
packages/message-relayer/src/relay-tx.ts
...ubmitter/src/batch-submitter/tx-batch-submitter.ts
...ckages/data-transport-layer/src/utils/contracts.ts
...h-submitter/src/batch-submitter/batch-submitter.ts
packages/data-transport-layer/src/utils/eth-tx.ts
.../batch-submitter/src/transaction-chain-contract.ts
.../l1-ingestion/handlers/sequencer-batch-appended.ts
...ackages/batch-submitter/src/utils/tx-submission.ts
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8282054...4016d5a. Read the comment docs.

let eoa: Account
before(() => {
// eslint-disable-next-line
before(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this? I think this would need to be an arrow function and the parent should be a "normal" function. Not 100% sure though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and it works, it will skip as expected when running on kovan

@tynes tynes merged commit 3f58aeb into regenesis/0.5.0 Nov 9, 2021
@tynes tynes deleted the test/1inch-deployer branch November 9, 2021 23:21
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants