feat: update mainnet deploy scripts#1723
Conversation
|
| export L1_FEE_WALLET_ADDRESS=0x391716d440c151c42cdf1c95c1d83a5427bca52c | ||
| export L1_CROSS_DOMAIN_MESSENGER_ADDRESS=0x25ace71c97B33Cc4729CF772ae268934F7ab5fA1 | ||
| export WHITELIST_OWNER=0x648E3e8101BFaB7bf5997Bd007Fb473786019159 | ||
| export GAS_PRICE_ORACLE_OWNER=0x648E3e8101BFaB7bf5997Bd007Fb473786019159 |
There was a problem hiding this comment.
This is the only value that I'm not confident in
There was a problem hiding this comment.
verified that this matches the k8s settings, but not sure if it should be different
There was a problem hiding this comment.
We shouldn't change the gas oracle owner, so its good
Codecov Report
@@ Coverage Diff @@
## regenesis/0.5.0 #1723 +/- ##
===================================================
- Coverage 72.64% 72.12% -0.52%
===================================================
Files 69 67 -2
Lines 2274 2167 -107
Branches 337 324 -13
===================================================
- Hits 1652 1563 -89
+ Misses 622 604 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Replaces #1693 |
| export L1_FEE_WALLET_ADDRESS=0x391716d440c151c42cdf1c95c1d83a5427bca52c | ||
| export L1_CROSS_DOMAIN_MESSENGER_ADDRESS=0x25ace71c97B33Cc4729CF772ae268934F7ab5fA1 | ||
| export WHITELIST_OWNER=0x648E3e8101BFaB7bf5997Bd007Fb473786019159 | ||
| export GAS_PRICE_ORACLE_OWNER=0x648E3e8101BFaB7bf5997Bd007Fb473786019159 |
There was a problem hiding this comment.
verified that this matches the k8s settings, but not sure if it should be different
| --ovm-sequencer-address 0x6887246668a3b87F54DeB3b94Ba47a6f63F32985 \ | ||
| --ovm-proposer-address 0x473300df21D047806A082244b417f96b32f13A33 \ | ||
| --ovm-address-manager-owner 0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A \ |
There was a problem hiding this comment.
what should these be compared against?
There was a problem hiding this comment.
They aren't really changed, the diff is just a bit messed up.
But I believe the right way to check is to ensure that they match what's in the AddressManager now.
There was a problem hiding this comment.
Should be compared against the existing mainnet configuration values
| --ovm-sequencer-address 0x6887246668a3b87F54DeB3b94Ba47a6f63F32985 \ | ||
| --ovm-proposer-address 0x473300df21D047806A082244b417f96b32f13A33 \ | ||
| --ovm-address-manager-owner 0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A \ | ||
| --gasprice 150000000000 \ |
There was a problem hiding this comment.
This may not be the best value to use at the time, will need to determine what it should be at deploy time
There was a problem hiding this comment.
This could be determined at runtime using seth but unsure if we want to add another dependency to this script
There was a problem hiding this comment.
seth basefee or seth gas-price
| --ovm-sequencer-address 0x6887246668a3b87F54DeB3b94Ba47a6f63F32985 \ | ||
| --ovm-proposer-address 0x473300df21D047806A082244b417f96b32f13A33 \ | ||
| --ovm-address-manager-owner 0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A \ | ||
| --gasprice 150000000000 \ |
There was a problem hiding this comment.
This could be determined at runtime using seth but unsure if we want to add another dependency to this script
| --ovm-sequencer-address 0x6887246668a3b87F54DeB3b94Ba47a6f63F32985 \ | ||
| --ovm-proposer-address 0x473300df21D047806A082244b417f96b32f13A33 \ | ||
| --ovm-address-manager-owner 0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A \ | ||
| --gasprice 150000000000 \ |
There was a problem hiding this comment.
seth basefee or seth gas-price
| --ovm-sequencer-address 0x6887246668a3b87F54DeB3b94Ba47a6f63F32985 \ | ||
| --ovm-proposer-address 0x473300df21D047806A082244b417f96b32f13A33 \ | ||
| --ovm-address-manager-owner 0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A \ |
There was a problem hiding this comment.
They aren't really changed, the diff is just a bit messed up.
But I believe the right way to check is to ensure that they match what's in the AddressManager now.
| --ovm-proposer-address 0x473300df21D047806A082244b417f96b32f13A33 \ | ||
| --ovm-address-manager-owner 0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A \ | ||
| --gasprice 150000000000 \ | ||
| --num-deploy-confirmations 12 \ |
There was a problem hiding this comment.
This might be overkill?
It's about 3 minutes. I count 9 files with the upgrade tag, each of which has at least one transaction. So with no delay getting a tx mined, and not counting time for validation and signing, this will take half an hour.
Some quick searching suggests that reorgs greater than 2 blocks are extremely rare
https://ethereum.stackexchange.com/questions/62000/distribution-of-chain-reorganization-events/73007
https://etherscan.io/blocks_forked
There was a problem hiding this comment.
Maybe 3 or 4 confs then?
There was a problem hiding this comment.
Reduced to 4 confs.
| CONTRACTS_TARGET_NETWORK=mainnet \ | ||
| npx hardhat etherscan-verify --network mainnet | ||
| npx hardhat etherscan-verify \ | ||
| --network mainnet \ | ||
| --sleep |
There was a problem hiding this comment.
Might be worth keeping for now given that we don't throw if the etherscan validation fails the first time around.
smartcontracts
force-pushed
the
sc/update-mainnet-deploy-scripts
branch
from
7e97eb5 to
0002116
Compare
smartcontracts
force-pushed
the
sc/update-mainnet-deploy-scripts
branch
from
0002116 to
b17c6e5
Compare
5 participants
Description
Updates the mainnet deploy scripts with what I believe to be the correct values for each variable. Must be merged by today.