Skip to content

Comments

revert: tweaks to FDG legibility#17209

Merged
smartcontracts merged 2 commits intoproposal/op-contracts/v4.1.0from
sc/rv-fdg-tweaks
Aug 26, 2025
Merged

revert: tweaks to FDG legibility#17209
smartcontracts merged 2 commits intoproposal/op-contracts/v4.1.0from
sc/rv-fdg-tweaks

Conversation

@smartcontracts
Copy link
Contributor

Description
Reverts #17010 in the U16a proposal branch.

@smartcontracts smartcontracts requested a review from a team as a code owner August 25, 2025 20:44
@smartcontracts
Copy link
Contributor Author

You can verify that this is a full revert by looking at a comparison with the v4.0.0 proposal branch and confirming that there are no longer any changes to the FDG contracts. You can also use this comparison to check for any other changes that might need to be reverted (probably nothing else needs to be reverted). https://github.com/ethereum-optimism/optimism/compare/proposal/op-contracts/v4.0.0..sc/rv-fdg-tweaks

@smartcontracts
Copy link
Contributor Author

Just forced-push a change to keep a clean history but we probably don't need to be too strict about that so I'll add commits regularly from now on. The change in the latest push was to make sure that the version being used was also updated in the StandardValidator code. We will need to deploy a new StandardValidator for U16a.

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (a1a200a) to head (165e561).
⚠️ Report is 1 commits behind head on proposal/op-contracts/v4.1.0.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           proposal/op-contracts/v4.1.0   #17209       +/-   ##
=================================================================
+ Coverage                         62.42%   96.29%   +33.86%     
=================================================================
  Files                               192      106       -86     
  Lines                             12305     4584     -7721     
=================================================================
- Hits                               7682     4414     -3268     
+ Misses                             4465      170     -4295     
+ Partials                            158        0      -158     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ock/src/L1/OPContractsManagerStandardValidator.sol 100.00% <100.00%> (ø)
...contracts-bedrock/src/dispute/FaultDisputeGame.sol 98.48% <100.00%> (+<0.01%) ⬆️
...ts-bedrock/src/dispute/PermissionedDisputeGame.sol 100.00% <100.00%> (ø)
...acts-bedrock/src/dispute/SuperFaultDisputeGame.sol 98.03% <100.00%> (+0.01%) ⬆️
...drock/src/dispute/SuperPermissionedDisputeGame.sol 100.00% <100.00%> (ø)

... and 86 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me - just have the open question on the StandardValidator version number.

@smartcontracts smartcontracts merged commit 6237f0a into proposal/op-contracts/v4.1.0 Aug 26, 2025
68 checks passed
@smartcontracts smartcontracts deleted the sc/rv-fdg-tweaks branch August 26, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants