revert: tweaks to FDG legibility#17209
revert: tweaks to FDG legibility#17209smartcontracts merged 2 commits intoproposal/op-contracts/v4.1.0from
Conversation
|
You can verify that this is a full revert by looking at a comparison with the v4.0.0 proposal branch and confirming that there are no longer any changes to the FDG contracts. You can also use this comparison to check for any other changes that might need to be reverted (probably nothing else needs to be reverted). https://github.com/ethereum-optimism/optimism/compare/proposal/op-contracts/v4.0.0..sc/rv-fdg-tweaks |
09c4a9e to
c587995
Compare
|
Just forced-push a change to keep a clean history but we probably don't need to be too strict about that so I'll add commits regularly from now on. The change in the latest push was to make sure that the version being used was also updated in the StandardValidator code. We will need to deploy a new StandardValidator for U16a. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## proposal/op-contracts/v4.1.0 #17209 +/- ##
=================================================================
+ Coverage 62.42% 96.29% +33.86%
=================================================================
Files 192 106 -86
Lines 12305 4584 -7721
=================================================================
- Hits 7682 4414 -3268
+ Misses 4465 170 -4295
+ Partials 158 0 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
packages/contracts-bedrock/src/L1/OPContractsManagerStandardValidator.sol
Outdated
Show resolved
Hide resolved
mbaxter
left a comment
There was a problem hiding this comment.
The diff looks good to me - just have the open question on the StandardValidator version number.
6237f0a
into
proposal/op-contracts/v4.1.0
Description
Reverts #17010 in the U16a proposal branch.