Skip to content

Comments

feat: make the cwia arg layout human readable#17010

Merged
stevennevins merged 11 commits intodevelopfrom
feat/readable-cwia-arg-positions
Aug 15, 2025
Merged

feat: make the cwia arg layout human readable#17010
stevennevins merged 11 commits intodevelopfrom
feat/readable-cwia-arg-positions

Conversation

@stevennevins
Copy link
Contributor

Description

Use base 10 values for CWIA positions in call data

Improve readability of these functions for updates

Tests

Non-functional update

@stevennevins stevennevins requested a review from a team as a code owner August 11, 2025 15:59
@stevennevins stevennevins requested a review from mds1 August 11, 2025 15:59
@stevennevins stevennevins requested a review from mbaxter August 13, 2025 18:20
@stevennevins stevennevins force-pushed the feat/readable-cwia-arg-positions branch from 486cfee to afab131 Compare August 13, 2025 20:02
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.28%. Comparing base (bbe533d) to head (030501c).
⚠️ Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17010       +/-   ##
============================================
+ Coverage    81.88%   96.28%   +14.40%     
============================================
  Files          161      106       -55     
  Lines         9244     4580     -4664     
============================================
- Hits          7569     4410     -3159     
+ Misses        1528      170     -1358     
+ Partials       147        0      -147     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.28% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ock/src/L1/OPContractsManagerStandardValidator.sol 100.00% <100.00%> (ø)
...contracts-bedrock/src/dispute/FaultDisputeGame.sol 98.48% <100.00%> (-0.01%) ⬇️
...ts-bedrock/src/dispute/PermissionedDisputeGame.sol 100.00% <100.00%> (ø)
...acts-bedrock/src/dispute/SuperFaultDisputeGame.sol 98.02% <100.00%> (-0.02%) ⬇️
...drock/src/dispute/SuperPermissionedDisputeGame.sol 100.00% <100.00%> (ø)

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stevennevins stevennevins added this pull request to the merge queue Aug 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 15, 2025
@stevennevins stevennevins added this pull request to the merge queue Aug 15, 2025
Merged via the queue into develop with commit d1ed1d4 Aug 15, 2025
66 checks passed
@stevennevins stevennevins deleted the feat/readable-cwia-arg-positions branch August 15, 2025 21:03
janjakubnanista pushed a commit that referenced this pull request Aug 19, 2025
* feat: make the cwia arg layout human readable

* fix: bump semvers

* fix: add error to each interface

* chore: align comment for cwia layout

* fix: update semver lock

* fix: correct version bump for semver

* chore: bump semver lock

* fix: update versions for dg contracts in standard validator

* feat: update the semver

* chore: update semver

* fix: failing tests in OPCM
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
* feat: make the cwia arg layout human readable

* fix: bump semvers

* fix: add error to each interface

* chore: align comment for cwia layout

* fix: update semver lock

* fix: correct version bump for semver

* chore: bump semver lock

* fix: update versions for dg contracts in standard validator

* feat: update the semver

* chore: update semver

* fix: failing tests in OPCM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants