Skip to content

Comments

refactor: Remove PromoteSafeEvent#17161

Merged
pcw109550 merged 1 commit intodevelopfrom
pcw109550/rm-event-system-PromoteSafeEvent
Aug 20, 2025
Merged

refactor: Remove PromoteSafeEvent#17161
pcw109550 merged 1 commit intodevelopfrom
pcw109550/rm-event-system-PromoteSafeEvent

Conversation

@pcw109550
Copy link
Member

@pcw109550 pcw109550 commented Aug 20, 2025

Description

Removes PromoteSafeEvent.

PromoteSafeEvent was emitted from IndexingMode and EngineController. EngineController was the only one consumed the PromoteSafeEvent.

IndexingMode was injected with EngineController at #17061 as using the ForceResetNotifier interface. Added the EngineController interface to support more engine controller procedural method call like PromoteSafe method.

Tests

All existing tests pass.

@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.28%. Comparing base (2a67efc) to head (4182819).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17161       +/-   ##
============================================
+ Coverage    44.96%   96.28%   +51.32%     
============================================
  Files         1423      106     -1317     
  Lines       115112     4580   -110532     
============================================
- Hits         51755     4410    -47345     
+ Misses       59655      170    -59485     
+ Partials      3702        0     -3702     
Flag Coverage Δ
contracts-bedrock-tests 96.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1317 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcw109550 pcw109550 marked this pull request as ready for review August 20, 2025 11:24
@pcw109550 pcw109550 requested review from a team as code owners August 20, 2025 11:24
@pcw109550 pcw109550 requested review from protolambda and teddyknox and removed request for protolambda August 20, 2025 11:24
@pcw109550 pcw109550 added this pull request to the merge queue Aug 20, 2025
Merged via the queue into develop with commit 3b73ebb Aug 20, 2025
68 checks passed
@pcw109550 pcw109550 deleted the pcw109550/rm-event-system-PromoteSafeEvent branch August 20, 2025 16:37
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants