Skip to content

Comments

refactor: remove ForceResetEvent#17061

Merged
mds1 merged 16 commits intodevelopfrom
refactor/ForceResetEvent
Aug 19, 2025
Merged

refactor: remove ForceResetEvent#17061
mds1 merged 16 commits intodevelopfrom
refactor/ForceResetEvent

Conversation

@mds1
Copy link
Contributor

@mds1 mds1 commented Aug 13, 2025

No description provided.

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 57.29167% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.37%. Comparing base (25b7d01) to head (ff30bb9).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/driver/driver.go 0.00% 13 Missing ⚠️
op-node/rollup/attributes/attributes.go 0.00% 9 Missing ⚠️
op-node/node/node.go 0.00% 6 Missing ⚠️
op-program/client/driver/driver.go 0.00% 6 Missing ⚠️
op-node/rollup/interop/indexing/system.go 0.00% 3 Missing ⚠️
op-node/rollup/derive/deriver.go 0.00% 2 Missing ⚠️
op-node/rollup/derive/pipeline.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17061      +/-   ##
===========================================
- Coverage    45.77%   45.37%   -0.41%     
===========================================
  Files         1478     1478              
  Lines       120068   120100      +32     
===========================================
- Hits         54959    54491     -468     
- Misses       61265    61778     +513     
+ Partials      3844     3831      -13     
Flag Coverage Δ
cannon-go-tests-64 65.99% <ø> (-0.72%) ⬇️
contracts-bedrock-tests 96.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/engine/engine_controller.go 78.29% <100.00%> (-2.23%) ⬇️
op-node/rollup/engine/engine_reset.go 79.31% <100.00%> (-2.51%) ⬇️
op-node/rollup/engine/events.go 100.00% <100.00%> (ø)
op-node/rollup/engine/payload_success.go 89.28% <100.00%> (-1.90%) ⬇️
op-node/rollup/event.go 0.00% <ø> (ø)
op-node/rollup/sequencing/origin_selector.go 90.90% <100.00%> (+0.12%) ⬆️
op-node/rollup/derive/deriver.go 0.00% <0.00%> (ø)
op-node/rollup/derive/pipeline.go 0.00% <0.00%> (ø)
op-node/rollup/interop/indexing/system.go 19.10% <0.00%> (+0.19%) ⬆️
op-node/node/node.go 0.34% <0.00%> (-0.01%) ⬇️
... and 3 more

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mds1 mds1 force-pushed the refactor/ForceResetEvent branch from 404a7ff to 3497a46 Compare August 13, 2025 21:57
@mds1 mds1 force-pushed the refactor/ForceResetEvent branch from 3497a46 to 3b1ec92 Compare August 13, 2025 22:23
@mds1 mds1 marked this pull request as ready for review August 13, 2025 22:27
@mds1 mds1 requested review from a team as code owners August 13, 2025 22:27
@mds1 mds1 requested a review from protolambda August 13, 2025 22:27
@mds1 mds1 requested a review from a team as a code owner August 14, 2025 14:32
@mds1 mds1 force-pushed the refactor/ForceResetEvent branch from 224b830 to b4c6407 Compare August 14, 2025 23:34
@mds1 mds1 requested a review from a team as a code owner August 14, 2025 23:34
@mds1 mds1 requested a review from clabby August 14, 2025 23:34
@teddyknox teddyknox self-requested a review August 18, 2025 15:42
@mds1 mds1 enabled auto-merge August 19, 2025 00:09
@mds1 mds1 added this pull request to the merge queue Aug 19, 2025
Merged via the queue into develop with commit a4d51f0 Aug 19, 2025
68 checks passed
@mds1 mds1 deleted the refactor/ForceResetEvent branch August 19, 2025 01:26
janjakubnanista pushed a commit that referenced this pull request Aug 19, 2025
* refactor: remove ForceResetEvent

* style: go lint

* fix: missing SetEngController call

* fixes

* fix panics

* set resetters in op-program

* lint

* ci: bump go-tests-short timeout

* fix DerivationReady

* emit ConfirmPipelineResetEvent during ForceReset

* fix: add reset notifier for indexing mode

* doc: add todo comment
@ajsutton ajsutton mentioned this pull request Aug 20, 2025
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
* refactor: remove ForceResetEvent

* style: go lint

* fix: missing SetEngController call

* fixes

* fix panics

* set resetters in op-program

* lint

* ci: bump go-tests-short timeout

* fix DerivationReady

* emit ConfirmPipelineResetEvent during ForceReset

* fix: add reset notifier for indexing mode

* doc: add todo comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants