Skip to content

refactor: remove CrossUpdateRequestEvent, CrossUnsafeUpdateEvent, and CrossSafeUpdateEvent#17101

Merged
mds1 merged 7 commits into
developfrom
refactor/CrossUpdateRequestEvent
Aug 18, 2025
Merged

refactor: remove CrossUpdateRequestEvent, CrossUnsafeUpdateEvent, and CrossSafeUpdateEvent#17101
mds1 merged 7 commits into
developfrom
refactor/CrossUpdateRequestEvent

refactor: extract nil checks to helper method

baf92d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 18, 2025 in 1s

44.51% (-1.24%) compared to aa4db40

View this Pull Request on Codecov

44.51% (-1.24%) compared to aa4db40

Details

Codecov Report

❌ Patch coverage is 44.44444% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.51%. Comparing base (aa4db40) to head (baf92d7).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/status/status.go 0.00% 18 Missing ⚠️
op-node/rollup/driver/driver.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17101      +/-   ##
===========================================
- Coverage    45.75%   44.51%   -1.24%     
===========================================
  Files         1478     1423      -55     
  Lines       119949   115279    -4670     
===========================================
- Hits         54877    51321    -3556     
+ Misses       61226    60276     -950     
+ Partials      3846     3682     -164     
Files with missing lines Coverage Δ
op-node/rollup/driver/state.go 0.00% <ø> (ø)
op-node/rollup/engine/engine_controller.go 77.57% <100.00%> (+1.03%) ⬆️
op-node/rollup/engine/events.go 100.00% <ø> (+3.92%) ⬆️
op-node/rollup/driver/driver.go 0.00% <0.00%> (ø)
op-node/rollup/status/status.go 38.88% <0.00%> (-3.97%) ⬇️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.