Remove redundant declaration of address names#1695
Merged
smartcontracts merged 2 commits intoregenesis/0.5.0from Nov 9, 2021
Merged
Conversation
🦋 Changeset detectedLatest commit: 6f0fcf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## regenesis/0.5.0 #1695 +/- ##
================================================
Coverage 72.64% 72.64%
================================================
Files 69 69
Lines 2274 2274
Branches 337 337
================================================
Hits 1652 1652
Misses 622 622
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
maurelian
commented
Nov 4, 2021
Contributor
Author
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
I've found some places I've missed applying the object member access, so this is not quite ready, but appreciate the quick reviews coming in. :)
maurelian
force-pushed
the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
from
d03e032 to
cfc8b9b
Compare
maurelian
force-pushed
the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
from
88312e2 to
4835794
Compare
Contributor
|
Looking good, I'd rebase into one commit and should be good to go after approval |
maurelian
force-pushed
the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
from
2a0349b to
96bf7b4
Compare
maurelian
force-pushed
the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
2 times, most recently
from
be42c24 to
64b53f4
Compare
Contributor
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
Also note that there are other places in this repository where these names are being used. However, that could make a good first issue or two so I'd recommend not updating those values in this PR.
maurelian
force-pushed
the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
3 times, most recently
from
0bc574d to
07c5cb5
Compare
maurelian
force-pushed
the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
from
ab6cace to
f1af0af
Compare
smartcontracts
approved these changes
Nov 9, 2021
Contributor
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
LGTM, nice cleanup.
tynes
approved these changes
Nov 9, 2021
This commit adds an addressNames object, which should be used both for names in the address manager, and naming deployment artifacts. fix(contracts): Remove unused queue container test code feat(contracts): Split up managed and unmanaged names refactor(contracts): Move address names into a single nested object refactor(contracts): Make address keys similar to values chore: add changeset docs(contracts): Add a docstring to deployAndPostDeploy refactor(contracts): Remove unnecessary contract name If the Address Manager's name is the same as the contract artifact we don't need specify the contract name argument.
maurelian
force-pushed
the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
from
f1af0af to
6f0fcf2
Compare
smartcontracts
deleted the
maurelian/eng-1645-remove-redundant-declaration-of-address
branch
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Adds a path for finalizing L2 blocks, based off of the L1 block they were derived from. To accomplish this: 1. The derivation pipeline now attaches the L1 block that the L2 block was derived from, within `OpAttributesWithParent`. 2. The DA watcher actor now watches a stream of finalized L1 blocks, polled every 1m. 3. The engine actor now holds onto a map of `l1_block_number => highest_l2_block_in_epoch`, saturated when it receives attributes from the derivation actor. - When a new finalized L1 block is observed by the engine actor, it will find the highest L2 block whose batch data is contained within the finalized L1 chain, and finalize it (if it knows of any.) This approach is different than suggested by the tickets, but results in a more slim outcome that takes advantage of existing actors. ### Periphery changes - Some refactoring of the `OpAttributesWithParent` type. - The sync start algorithm now stops safe block traversal at the finalized head, to ensure it never assigns a safe block past it. - The `L1WatcherRpc` now uses a custom `BlockStream`, since alloy's `watch_blocks` stream doesn't dedup nor allow for observing anything other than head block updates. ### Result Finalized blocks are correctly streaming in 😄 <img width="1228" alt="Screenshot 2025-05-24 at 5 09 01 PM" src="https://github.com/user-attachments/assets/609184a5-35b8-4b04-a124-eeece8ef53e4" /> ### Meta closes #1693 closes #1694 closes #1695 closes #1696 closes #1698
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
## Overview Adds a path for finalizing L2 blocks, based off of the L1 block they were derived from. To accomplish this: 1. The derivation pipeline now attaches the L1 block that the L2 block was derived from, within `OpAttributesWithParent`. 2. The DA watcher actor now watches a stream of finalized L1 blocks, polled every 1m. 3. The engine actor now holds onto a map of `l1_block_number => highest_l2_block_in_epoch`, saturated when it receives attributes from the derivation actor. - When a new finalized L1 block is observed by the engine actor, it will find the highest L2 block whose batch data is contained within the finalized L1 chain, and finalize it (if it knows of any.) This approach is different than suggested by the tickets, but results in a more slim outcome that takes advantage of existing actors. ### Periphery changes - Some refactoring of the `OpAttributesWithParent` type. - The sync start algorithm now stops safe block traversal at the finalized head, to ensure it never assigns a safe block past it. - The `L1WatcherRpc` now uses a custom `BlockStream`, since alloy's `watch_blocks` stream doesn't dedup nor allow for observing anything other than head block updates. ### Result Finalized blocks are correctly streaming in 😄 <img width="1228" alt="Screenshot 2025-05-24 at 5 09 01 PM" src="https://github.com/user-attachments/assets/609184a5-35b8-4b04-a124-eeece8ef53e4" /> ### Meta closes #1693 closes #1694 closes #1695 closes #1696 closes #1698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The strings used to resolve system contracts in the Address Manager must be correct, but they are declared independently in many places.
This PR defines an exported object to act as a dictionary of correct names.