Skip to content

fix: uniswap immutables bug#1575

Merged
smartcontracts merged 3 commits intosc/surgery-basefrom
sc/surgery-fix-uni
Oct 14, 2021
Merged

fix: uniswap immutables bug#1575
smartcontracts merged 3 commits intosc/surgery-basefrom
sc/surgery-fix-uni

Conversation

@smartcontracts
Copy link
Contributor

Description
Fix surgery bug that impacted uniswap periphery contracts with immutables.

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2021

⚠️ No Changeset found

Latest commit: c337b34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1575 (3e15a04) into sc/surgery-base (43f4afc) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 3e15a04 differs from pull request most recent head c337b34. Consider uploading reports for the commit c337b34 to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                 @@
##           sc/surgery-base    #1575      +/-   ##
===================================================
- Coverage            73.62%   73.58%   -0.04%     
===================================================
  Files                   67       65       -2     
  Lines                 2207     2109      -98     
  Branches               324      310      -14     
===================================================
- Hits                  1625     1552      -73     
+ Misses                 582      557      -25     
Flag Coverage Δ
batch-submitter 61.74% <ø> (ø)
contracts 91.17% <ø> (+0.73%) ⬆️
core-utils 55.73% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/batch-submitter/hardhat.config.ts 100.00% <0.00%> (ø)
.../contracts/L1/messaging/L1CrossDomainMessenger.sol 96.77% <0.00%> (ø)
packages/message-relayer/hardhat.config.ts
packages/message-relayer/src/relay-tx.ts
.../contracts/L1/rollup/CanonicalTransactionChain.sol 87.93% <0.00%> (+2.88%) ⬆️
...contracts/contracts/libraries/utils/Lib_Buffer.sol 100.00% <0.00%> (+7.14%) ⬆️
...acts/contracts/L1/rollup/ChainStorageContainer.sol 80.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f4afc...c337b34. Read the comment docs.

@smartcontracts smartcontracts merged commit 992948f into sc/surgery-base Oct 14, 2021
@smartcontracts smartcontracts deleted the sc/surgery-fix-uni branch October 14, 2021 03:33
theochap pushed a commit that referenced this pull request Dec 10, 2025
### Description

Implements handling for the `opp2p_connectPeer` method using the
Multiaddr string.

This follows how [the monorepo parses the addr
string](https://github.com/ethereum-optimism/optimism/blob/51cb1a7523ac45e3c3703a1a2c6794b378f27cba/op-node/p2p/rpc_server.go#L353).

Closes #1575
theochap pushed a commit that referenced this pull request Jan 14, 2026
### Description

Implements handling for the `opp2p_connectPeer` method using the
Multiaddr string.

This follows how [the monorepo parses the addr
string](https://github.com/ethereum-optimism/optimism/blob/51cb1a7523ac45e3c3703a1a2c6794b378f27cba/op-node/p2p/rpc_server.go#L353).

Closes #1575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants