cannon: Drop version 6 support from MIPS64.sol#15664
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15664 +/- ##
===========================================
+ Coverage 45.97% 46.13% +0.16%
===========================================
Files 1284 1280 -4
Lines 105863 105424 -439
===========================================
- Hits 48669 48640 -29
+ Misses 53697 53283 -414
- Partials 3497 3501 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mbaxter
changed the title
Inphi
reviewed
May 2, 2025
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
just a quick feedback. Not comprehensive.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
smartcontracts
approved these changes
May 2, 2025
Contributor
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
Approving the Solidity diff!
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
* Drop v6 vm from MIPS64.sol * Add tests for MIPS64.sol constructor * Update test to use DeployUtils * Update mipsVersion in deploy script * Fix test names * Cut unused imports * Update another mips version reference * Update another mipsVersion literal, add some version helpers * Use experimental version for interopgen recipe * Calculate experimental and supported versions, add tests * Fix typo Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Fix bad merge from bot * Experimental version should be >= the current version * Tweak unsupported versions test * Delete unused contracts --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an oversight from #15616: drop v6 support from
MIPS64.sol.Also:
mipsVersionliterals pointing to the old version