cannon: Drop support for version 6 of the Cannon VM#15616
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15616 +/- ##
============================================
+ Coverage 46.00% 76.76% +30.75%
============================================
Files 1279 164 -1115
Lines 105490 9128 -96362
============================================
- Hits 48535 7007 -41528
+ Misses 53454 1989 -51465
+ Partials 3501 132 -3369
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
LGTM, just want to get input on how this interacts with op-deployer around how best to specify the right version of cannon for it to deploy. I like the CANNON vs CANNON_NEXT approach I think because op-deployer should generally just deploy the latest gov approved stuff, so it's ok that CANNON might change meaning from release to release and sometimes we need to be be able to deploy a feature toggled version which CANNON_NEXT can be used for. We only have to do extra plumbing if we ever have to support multiple future versions of cannon and let's just not do that again.
packages/contracts-bedrock/test/opcm/DeployImplementations.t.sol
Outdated
Show resolved
Hide resolved
…m#15616) * Pull Cannon version 6 from tagged docker image * Drop v6 from supported version helper * Update reproducible-prestate task - drop v6, move to v7 * Rework VMType handling * Update e2e tests - only run 'next' cannon if it is in development * Add some comments to Dockerfile.repro * Update dockerdiff file to check latest vm * Update cannon-prestate tasks * Update op-deployer/opcm MipsVersion to 7 * Drop requirement to test dclz/o backwards compatibility * Update alpha cannon tag to match convention * Continue building the next Cannon prestate * Update Dockerfile.diff go version to 1.23 * Drop go 1.22 test programs * Move MIPS_VERSION constant so it can be used in scripts and tests * Lint contracts
3 participants
Description
Drop support for
StateVersion6 of the Cannon VM which targets Go 1.22. Default toStateVersion7, which targets Go 1.23.Tests
Update references to the Cannon version in tests.
Metadata
Fixes #13447
Fixes #15591