Conversation
Inphi
force-pushed
the
inphi/cannon-new-insn
branch
from
40c4b93 to
3be4325
Compare
This brings back dclo/dclz support in cannon after it was reverted by 03f8875. The new instructions are part of the version 4 mt64 feature set.
Inphi
force-pushed
the
inphi/cannon-new-insn
branch
from
3be4325 to
433be54
Compare
ajsutton
reviewed
Apr 29, 2025
Contributor
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
The go side LGTM. I think the solidity makes sense as well but given the number of changes to avoid stack depth problems I think it's worth getting Meredith's review on it before merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15601 +/- ##
===========================================
- Coverage 45.97% 45.95% -0.02%
===========================================
Files 1279 1279
Lines 105478 105489 +11
===========================================
- Hits 48491 48477 -14
- Misses 53498 53523 +25
Partials 3489 3489
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mbaxter
approved these changes
Apr 29, 2025
Contributor
mbaxter
left a comment
mbaxter
left a comment
There was a problem hiding this comment.
lgtm - just left a few nits
packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
Outdated
Show resolved
Hide resolved
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
* cannon: Implement dclo|dclz This brings back dclo/dclz support in cannon after it was reverted by 03f8875. The new instructions are part of the version 4 mt64 feature set. * copy memory values to stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings back support for dclo/dclz instructions in cannon introduced in #14454 after it was reverted by 03f8875.
The new instructions are part of the version 4 mt64 feature set, alongside the eventfd syscall feature.