Add new 64-bit instructions to mipsevm README#15571
Merged
pauldowman merged 6 commits intodevelopfrom May 1, 2025
Merged
Conversation
pauldowman
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15571 +/- ##
===========================================
- Coverage 46.02% 43.92% -2.10%
===========================================
Files 1284 1174 -110
Lines 105855 100890 -4965
===========================================
- Hits 48719 44318 -4401
+ Misses 53630 53073 -557
+ Partials 3506 3499 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mbaxter
reviewed
Apr 28, 2025
pauldowman
commented
Apr 29, 2025
mbaxter
reviewed
Apr 30, 2025
Contributor
mbaxter
left a comment
mbaxter
left a comment
There was a problem hiding this comment.
looks good - just left a comment on a few "4 byte" references that need to be updated
pauldowman
force-pushed
the
pd/cannon-readme-changes
branch
from
18510e1 to
69bb9e8
Compare
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
* Remove outdated warning * Add new 64-bit instructions to the MIPS EVM README * Add `lwu` instruction to mipsevm README * More MIPS64 README updates * Update memory access description for MIPS64 * Fix one more 4-byte reference in Cannon README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new 64-bit instructions to mipsevm README.
Closes #13016
@mbaxter I didn't put them into a new, separate section as you suggested, since we now only have MIP64 and not multiple versions. But I don't feel strongly, happy to separate them if you think it's better that way.