cannon: Add feature toggling to MIPS VM contracts#15487
Merged
Conversation
ajsutton
reviewed
Apr 22, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15487 +/- ##
===========================================
- Coverage 46.67% 46.55% -0.12%
===========================================
Files 1271 1271
Lines 105156 105166 +10
===========================================
- Hits 49080 48962 -118
- Misses 52609 52746 +137
+ Partials 3467 3458 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
94b31f4 to
adb3d55
Compare
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
…15487) * cannon: Add state version to MIPS contract. * Formatting. * cannon: Update EVM tests to init contract correctly. * Fix contracts checks. * op-deployer: Fix test * Formatting * Fix interfaces. * Update MIPS2 version. * cleanup: Cut println * Remove MIPS contracts from code freeze * Drop legacy MipsVersion 2 * Run semver-lock * Drop -beta suffix from version * Run semver-lock * cleanup: Reorganize MIPS64 imports --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on PR #15425.
Add feature toggling to
MIPS2andMIPS64contracts. Feature toggling is enabled by injecting the targetStateVersioninto the MIPS contracts. The VM's behavior can then be changed conditionally based on theStateVersionvalue. For example:With feature toggling, we can maintain multiple VM versions in
develop: the current VM as well as future iterations of the VM that are still in development. This allows us to continue to release the current VM if necessary, while developing the next version(s) in parallel.Other changes:
op-deployerand other deployment scripts to use themipsVersionparameter as follows:StateVersionfor the 64-bit VM.Tests
StateVersionparameter into contracts where required.MipsVersionparameter.Metadata
Part of: #13447