Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads… #14190

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

axelKingsley
Copy link
Contributor

…. (#13923)"

This reverts commit a3c8069.

The commit was causing immediate crashes, only observed when running in live environments like Kurtosis. To get develop healthy for release tagging, I would like to remove this commit until it can be fixed and restored.

@axelKingsley axelKingsley requested review from a team as code owners February 5, 2025 21:27
@protolambda protolambda enabled auto-merge February 5, 2025 21:33
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (a96a098) to head (226089a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
op-service/metrics/ref_metrics.go 62.50% 3 Missing ⚠️
op-node/metrics/metrics.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a96a098) and HEAD (226089a). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a96a098) HEAD (226089a)
cannon-go-tests-64 2 0
cannon-go-tests-32 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14190       +/-   ##
============================================
- Coverage    66.93%   42.08%   -24.85%     
============================================
  Files           57      832      +775     
  Lines         4672    75169    +70497     
============================================
+ Hits          3127    31636    +28509     
- Misses        1376    40730    +39354     
- Partials       169     2803     +2634     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-supervisor/metrics/metrics.go 74.75% <ø> (ø)
op-supervisor/metrics/noop.go 42.85% <ø> (ø)
op-supervisor/supervisor/backend/backend.go 32.05% <100.00%> (ø)
op-supervisor/supervisor/backend/chain_metrics.go 53.84% <ø> (ø)
op-supervisor/supervisor/backend/db/db.go 10.44% <100.00%> (ø)
op-supervisor/supervisor/backend/db/update.go 0.00% <ø> (ø)
op-node/metrics/metrics.go 83.73% <0.00%> (ø)
op-service/metrics/ref_metrics.go 95.16% <62.50%> (ø)

... and 881 files with indirect coverage changes

@axelKingsley axelKingsley force-pushed the revert-supervisor-metrics branch from f25c805 to 4060f9c Compare February 5, 2025 21:52
@mslipper mslipper force-pushed the revert-supervisor-metrics branch from 4060f9c to 226089a Compare February 5, 2025 22:08
@protolambda protolambda added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit ab6283f Feb 5, 2025
45 checks passed
@protolambda protolambda deleted the revert-supervisor-metrics branch February 5, 2025 22:46
alcueca pushed a commit that referenced this pull request Feb 7, 2025
alcueca pushed a commit that referenced this pull request Feb 7, 2025
alcueca pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants