Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interop: Add metrics to track CrossUnsafe and CrossSafe heads. #13923

Merged
merged 3 commits into from
Feb 4, 2025
Merged

interop: Add metrics to track CrossUnsafe and CrossSafe heads. #13923

merged 3 commits into from
Feb 4, 2025

Conversation

tyler-smith
Copy link
Contributor

@tyler-smith tyler-smith commented Jan 22, 2025 •
edited by protolambda
Loading

  • Update RefMetrics to allow callers to add additional tags
  • Add CrossUnsafe and CrossSafe ref metrics in the supervisor, tagged with chain ids, so we can monitor the progression of these heads

Fix #13760

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (436a58a) to head (eda078a).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #13923       +/-   ##
============================================
+ Coverage    46.34%   94.43%   +48.09%     
============================================
  Files          996      108      -888     
  Lines        84339     4640    -79699     
============================================
- Hits         39089     4382    -34707     
+ Misses       42289      258    -42031     
+ Partials      2961        0     -2961
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 888 files with indirect coverage changes

@tyler-smith tyler-smith marked this pull request as ready for review January 22, 2025 17:30
@tyler-smith tyler-smith requested review from a team as code owners January 22, 2025 17:30
@tynes
Copy link
Contributor

tynes commented Jan 22, 2025

This seems sane to me

@protolambda
Copy link
Contributor

Can you rebase this, and go over the review suggestions? I'd like to get this merged after

@protolambda protolambda added the H-interop Hardfork: change planned for interop upgrade label Feb 4, 2025
@protolambda protolambda added this to the Interop: Stable Devnet milestone Feb 4, 2025
@tyler-smith tyler-smith force-pushed the ts/metrics-2 branch 2 times, most recently from 8b415c7 to 7358b8a Compare February 4, 2025 21:32
@tyler-smith
Copy link
Contributor Author

  • Rebased
  • Moved the new metrics to the DB level
  • Added a simple test that Backend metrics get fired

@protolambda protolambda added this pull request to the merge queue Feb 4, 2025
Merged via the queue into develop with commit a3c8069 Feb 4, 2025
45 checks passed
@protolambda protolambda deleted the ts/metrics-2 branch February 4, 2025 22:38
axelKingsley added a commit that referenced this pull request Feb 5, 2025
@axelKingsley
Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads. (
f25c805 
#13923)"

This reverts commit a3c8069.
@axelKingsley axelKingsley mentioned this pull request Feb 5, 2025
Merged
axelKingsley added a commit that referenced this pull request Feb 5, 2025
@axelKingsley
Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads. (
4060f9c 
#13923)"

This reverts commit a3c8069.
mslipper pushed a commit that referenced this pull request Feb 5, 2025
@axelKingsley @mslipper
Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads. (
226089a 
#13923)"

This reverts commit a3c8069.
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
@axelKingsley
Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads. (
ab6283f 
#13923)" (#14190)

This reverts commit a3c8069.
@tyler-smith tyler-smith mentioned this pull request Feb 6, 2025
Merged
alcueca pushed a commit that referenced this pull request Feb 7, 2025
@axelKingsley
Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads. (
13a2ac1 
#13923)" (#14190)

This reverts commit a3c8069.
alcueca pushed a commit that referenced this pull request Feb 7, 2025
@axelKingsley
Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads. (
fbc476a 
#13923)" (#14190)

This reverts commit a3c8069.
alcueca pushed a commit that referenced this pull request Feb 7, 2025
@axelKingsley
Revert "interop: Add metrics to track CrossUnsafe and CrossSafe heads. (
2af1764 
#13923)" (#14190)

This reverts commit a3c8069.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley is a code owner automatically assigned from ethereum-optimism/interop

Assignees
No one assigned
Labels
H-interop Hardfork: change planned for interop upgrade
Projects
Interoperability
Status: Done
Milestone
Interop: Stable Devnet
Development

Successfully merging this pull request may close these issues.

Interop: Add more metrics to op-supervisor
3 participants
@tyler-smith @tynes @protolambda