txmgr/Queue: add additional assertions to test to check for tx ordering#13124
Merged
sebastianst merged 7 commits intodevelopfrom Dec 2, 2024
Merged
txmgr/Queue: add additional assertions to test to check for tx ordering#13124sebastianst merged 7 commits intodevelopfrom
sebastianst merged 7 commits intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13124 +/- ##
===========================================
- Coverage 44.51% 42.78% -1.73%
===========================================
Files 801 745 -56
Lines 72026 67361 -4665
===========================================
- Hits 32059 28818 -3241
+ Misses 37359 36113 -1246
+ Partials 2608 2430 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
geoknee
changed the title
geoknee
force-pushed
the
gk/txmgr-queue-ordering-test
branch
from
7c46ffe to
0e76129
Compare
sebastianst
reviewed
Dec 2, 2024
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
sebastianst
approved these changes
Dec 2, 2024
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
…ng (#13124) * add additional assertions to test to check for tx ordering * enhance test to handle tx confirmation ID ordering * increase size of 0th tx to expose race condition * change approach since the backend does not order txs by nonce * tidy * clarify * Update op-service/txmgr/queue_test.go Co-authored-by: Sebastian Stammler <seb@oplabs.co> --------- Co-authored-by: Sebastian Stammler <seb@oplabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #13120 , this adds a test which exposes the existing risk of txs being confirmed out of order. This test fails without the fix of #13120.