txmgr: Queue.Send() uses q.txMgr.SendAsync#13120
Merged
Conversation
This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13120 +/- ##
===========================================
- Coverage 44.46% 42.74% -1.73%
===========================================
Files 798 742 -56
Lines 71682 67028 -4654
===========================================
- Hits 31874 28648 -3226
+ Misses 37224 35977 -1247
+ Partials 2584 2403 -181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It doesn't preserve the nonces like the production txMgr does.
BrianBland
reviewed
Nov 27, 2024
mdehoog
reviewed
Nov 27, 2024
mdehoog
approved these changes
Nov 27, 2024
ajsutton
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission.
Description
Updates the txMgr
Queue.Send()entrypoint to usetxMgr.SendAsync()Tests
See #13124
Additional context
Since Holocene, the order of batches landing on chain must be strictly adhered to. The batcher has been hardened to keep batches ordered before they get to the txMgr, but the txMgr fails to preserve the order of txs that the batcher sends to it. This caused a safe head stall on Base Sepolia.
The changes here also affect
op-challenger.Metadata
Fixes #12947