Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove thin wrapper _run() function overload #13101

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

maurelian
Copy link
Contributor

No description provided.

@maurelian maurelian marked this pull request as ready for review November 26, 2024 15:45
@maurelian maurelian requested a review from a team as a code owner November 26, 2024 15:45
@maurelian maurelian requested review from refcell and removed request for a team November 26, 2024 15:45
Base automatically changed from maur/cleanup-deploy-6 to develop December 3, 2024 15:11
@maurelian maurelian force-pushed the maur/cleanup-deploy-7 branch from d9c4f05 to df223c4 Compare December 3, 2024 17:34
@maurelian maurelian added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit f2eaaa8 Dec 3, 2024
42 checks passed
@maurelian maurelian deleted the maur/cleanup-deploy-7 branch December 3, 2024 17:51
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.66%. Comparing base (3435fcc) to head (df223c4).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13101      +/-   ##
===========================================
- Coverage    44.25%   42.66%   -1.60%     
===========================================
  Files          807      751      -56     
  Lines        72694    68029    -4665     
===========================================
- Hits         32173    29023    -3150     
+ Misses       37905    36566    -1339     
+ Partials      2616     2440     -176     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 64 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants