feat: remove unused onlyTestnetOrDevnet modifier #13086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 25, 2024
maurelian
force-pushed
the
maur/cleanup-deploy-4
branch
from
710e7fa
to
2e86495
Compare
maurelian
changed the base branch from
maur/cleanup-deploy-2
to
maur/cleanup-deploy-5
maurelian
force-pushed
the
maur/cleanup-deploy-5
branch
from
764a4c8
to
9335916
Compare
maurelian
force-pushed
the
maur/cleanup-deploy-4
branch
from
2e86495
to
23c7d5c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13086 +/- ##
===========================================
- Coverage 44.29% 42.67% -1.62%
===========================================
Files 798 742 -56
Lines 71617 66952 -4665
===========================================
- Hits 31720 28574 -3146
+ Misses 37324 35974 -1350
+ Partials 2573 2404 -169
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurelian
force-pushed
the
maur/cleanup-deploy-4
branch
from
23c7d5c
to
c89c5fd
Compare
maurelian
commented
Nov 26, 2024
smartcontracts
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some unused code.
Not sure why we ever needed it in the past.