build: migrate op-node and op-proposer to just#13042
Merged
Conversation
sigma
force-pushed
the
sigma/just-migration
branch
3 times, most recently
from
c6ef3c1 to
34ea6bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13042 +/- ##
===========================================
- Coverage 44.55% 42.84% -1.72%
===========================================
Files 799 743 -56
Lines 71845 67180 -4665
===========================================
- Hits 32009 28781 -3228
+ Misses 37230 35971 -1259
+ Partials 2606 2428 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
sigma
force-pushed
the
sigma/just-migration
branch
9 times, most recently
from
91068fc to
691b72b
Compare
This will enable making use of JUSTFLAGS in the main Makefile for migrated targets.
For some unclear reason runs in CI environment are invalid (they generate some "empty" calls to the private target). Sidestep the issue for now.
- VERSION_META variable - go_generate target
sigma
force-pushed
the
sigma/just-migration
branch
from
691b72b to
1f18bb9
Compare
mslipper
approved these changes
Nov 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* build(just): factor out flags code This will enable making use of JUSTFLAGS in the main Makefile for migrated targets. * fix(just): parallel support For some unclear reason runs in CI environment are invalid (they generate some "empty" calls to the private target). Sidestep the issue for now. * build(just): add more helpers - VERSION_META variable - go_generate target * build(op-proposer): migrate build to just * build(op-node): migrate build to just * fix(build): rewire just-migrated targets --------- Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Contributor
|
It looks like the README.md of the Line 70 in 3a97042 Also linking outdated docs issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change migrates op-node and op-proposer builds to just.
It also:
can be independently included in the main Makefile
deprecation notices at the top level
Tests
All targets tested manually.
Metadata