Conversation
semver-lock Co-Authored-By: Minhyuk Kim <kimminhyuk1004@gmail.com> Co-Authored-By: Taem Park <wwwee98@gmail.com> Co-Authored-By: Park Changwan <pcw109550@gmail.com> Co-Authored-By: protolambda <proto@protolambda.com>
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
from
4d750e2 to
c001b7b
Compare
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
2 times, most recently
from
eb16947 to
73d26e0
Compare
clabby
requested review from
ajsutton,
mds1 and
skeletor-spaceman
and removed request for
skeletor-spaceman
mds1
reviewed
Nov 20, 2024
mds1
reviewed
Nov 20, 2024
ajsutton
reviewed
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12994 +/- ##
===========================================
- Coverage 68.78% 66.77% -2.02%
===========================================
Files 56 56
Lines 4665 4665
===========================================
- Hits 3209 3115 -94
- Misses 1274 1378 +104
+ Partials 182 172 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
from
6634cd7 to
d1eefc8
Compare
mds1
reviewed
Nov 20, 2024
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
from
d1eefc8 to
0e72ee7
Compare
mds1
reviewed
Nov 20, 2024
mds1
reviewed
Nov 20, 2024
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
3 times, most recently
from
cf65f44 to
c416083
Compare
Contributor
Author
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
from
c416083 to
ee75fad
Compare
mds1
reviewed
Nov 20, 2024
mds1
reviewed
Nov 20, 2024
mds1
approved these changes
Nov 20, 2024
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
from
4bbc06b to
549e4f8
Compare
ajsutton
approved these changes
Nov 20, 2024
clabby
force-pushed
the
cl/vendorize-riscv-sol
branch
from
b68bbcb to
e337bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Vendors the
RISCV.solcontract fromasteriscinto the monorepo. The source contract, and its tests (as they are still dependent on the nativeasteriscVM), will continue to live over inasterisc. When we need to perform an upgrade involving this contract, changes will be upstreamed.This is to make the integration of
asteriscintoop-deployerand the standard upgrade process less painful. Longer term, we will think about ways to enable use of other repositories' contracts.