Merged
Conversation
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 12, 2024
mds1
reviewed
Nov 13, 2024
mds1
reviewed
Nov 13, 2024
mds1
reviewed
Nov 13, 2024
mds1
reviewed
Nov 13, 2024
mds1
reviewed
Nov 13, 2024
blmalone
reviewed
Nov 14, 2024
clabby
reviewed
Nov 19, 2024
maurelian
force-pushed
the
L1-upgrades
branch
from
f86a99c to
34679b3
Compare
tynes
reviewed
Nov 20, 2024
tynes
reviewed
Nov 20, 2024
tynes
reviewed
Nov 20, 2024
tynes
reviewed
Nov 20, 2024
tynes
reviewed
Nov 20, 2024
tynes
reviewed
Nov 20, 2024
mds1
reviewed
Nov 20, 2024
mslipper
reviewed
Nov 20, 2024
tynes
reviewed
Nov 21, 2024
maurelian
force-pushed
the
L1-upgrades
branch
from
e7a7285 to
15af9a9
Compare
Inphi
reviewed
Nov 26, 2024
| contracts within one block. | ||
| - **Declarative design:** As much as possible, a developer should be able to simply indicate what | ||
| bytecode should be deployed, and what storage values (if any) should be initialized or modified. | ||
| - **Deterministic upgrade calldata:** The exact calldata to be submitted during the upgrade should |
Contributor
There was a problem hiding this comment.
@maurelian The AnchorStateRegistry is a possible exception to this where the calldata is based on recent chain state and that state cannot be known at the time of the governance proposal. While we can relax this chain state requirement for initializing the ASR, perhaps it would be good to callout this as design principle when writing smart contract initializers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describes a fully onchain upgrade process.