Add coverage to packages beyond contracts#1297
Add coverage to packages beyond contracts#1297rajivpo wants to merge 4 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: acccf17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @rajivpo thanks for the PR! Do you mind explaining a bit about how |
|
Do you also mind squashing your commits into a single commit? |
Codecov Report
@@ Coverage Diff @@
## develop #1297 +/- ##
========================================
Coverage 86.05% 86.05%
========================================
Files 49 49
Lines 1936 1936
Branches 307 307
========================================
Hits 1666 1666
Misses 270 270
Continue to review full report at Codecov.
|
24be309 to
dce4c3f
Compare
| env: | ||
| CC_SECRET: ${{ secrets.CC_SECRET }} | ||
|
|
||
| # A hack that allows running a job only if a specific directory changed. |
There was a problem hiding this comment.
I figured i could remove this entire block now that there's coverage across all ts-packages, but if there's a good reason to keep this, happy to add back in.
9ab1df6 to
dce4c3f
Compare
|
@tynes does this suffice? |
|
Should have a bit more time this week - will continue adding to coverage to packages |
|
Thanks for the contribution! In line with what @tynes said above, can we also add the Codecov report run on the respective package readme, same way we do for contracts https://github.com/ethereum-optimism/optimism/tree/develop/packages/contracts |
8dc7276 to
0097df1
Compare
|
@rajivpo heya, just looking at the last commit and seeing that codecov is now just on the main readme, as opposed to what we agreed above which was to add the Codecov report run on each of the respective package readme. Basically I personally think that coverage per package is more meaningful than overall monorepo coverage. Sorry if my comment above was what confused you! |
|
oh okok yes this makes a lot more sense, I think this can be done with flags via codecov, but will need to double check |
|
Given how messy this is, I'm going to close this out as a much cleaner version of this is in development in #1412 |
Description
Added the ability to surface test coverage metrics for all relevant packages. This is the first of hopefully a few PRs I want to submit to improve test coverage across various packages (probably starting with
core-utilsas it's the easiest) and figured having the ability to surface where coverage is lacking in an automated fashion would be helpful for development.I've also seen repos hook up coverage numbers to their homepages, and if this is a desired feature, I'm happy to investigate. There's also probably an opportunity to ensure that coverage isn't decreasing as a pre-commit hook, and am happy to spend time implementing that would be helpful.
Additional context
Metadata