Skip to content

Add dual integration tests to SNX test suite#1261

Closed
K-Ho wants to merge 1 commit intodevelopfrom
K-Ho-patch-1
Closed

Add dual integration tests to SNX test suite#1261
K-Ho wants to merge 1 commit intodevelopfrom
K-Ho-patch-1

Conversation

@K-Ho
Copy link
Copy Markdown
Contributor

@K-Ho K-Ho commented Jul 12, 2021

Description
Adds "dual" integration tests (deposits and withdraws) to the external SNX test suite workflow

Fixes OP-1128

Adds "dual" integration tests (deposits and withdraws) to the external SNX test suite
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 12, 2021

⚠️ No Changeset found

Latest commit: a3fab65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Jul 12, 2021

Will be good to merge once we see it pass here: https://github.com/ethereum-optimism/optimism/actions/runs/1023991800

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Jul 12, 2021

It ran out of memory, I think this needs to be split up into different tasks that run after each other

@K-Ho
Copy link
Copy Markdown
Contributor Author

K-Ho commented Jul 13, 2021

It ran out of memory, I think this needs to be split up into different tasks that run after each other

looked like it didn't even get past spinning the Optimism stack up, re-running now

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Aug 6, 2021

@K-Ho - Is this still useful?

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Aug 16, 2021

@K-Ho Could you provide an update that includes:
1 - how to take advantage of this functionality?
2 - is this still useful?

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Sep 21, 2021

@K-Ho Any updates on this?

@K-Ho
Copy link
Copy Markdown
Contributor Author

K-Ho commented Sep 21, 2021

@elenadimitrova is taking this over - she was getting issues running these tests (as was I) and is debugging with Synthetix in their discord

@K-Ho K-Ho closed this Sep 21, 2021
@K-Ho K-Ho deleted the K-Ho-patch-1 branch November 4, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants