cannon: use constant instead of magic value for solidity part#12484
Merged
Inphi merged 2 commits intoethereum-optimism:developfrom Oct 17, 2024
Merged
cannon: use constant instead of magic value for solidity part#12484Inphi merged 2 commits intoethereum-optimism:developfrom
Inphi merged 2 commits intoethereum-optimism:developfrom
Conversation
zhiqiangxu
force-pushed
the
calling_convention_solidity
branch
from
6612bea to
5bb45c5
Compare
Inphi
reviewed
Oct 16, 2024
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
L:ooks good. Could you also bump the beta semver in MIPS.sol and MIPS2.sol? You'll have to also generate the semver-lock file using just semver-lock.
Contributor
Author
Done. |
Inphi
approved these changes
Oct 17, 2024
zhiqiangxu
force-pushed
the
calling_convention_solidity
branch
2 times, most recently
from
676d696 to
b62c6c8
Compare
Contributor
|
@zhiqiangxu Thanks. There's a merge conflict in the semver. Could you take a look? |
zhiqiangxu
force-pushed
the
calling_convention_solidity
branch
from
b62c6c8 to
928d968
Compare
Contributor
Author
Done. |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…um-optimism#12484) * cannon: use constant instead of magic value for solidity part * update version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for this one, which does the same to the solidity part.