-
Notifications
You must be signed in to change notification settings - Fork 3.9k
cannon: use constant instead of magic value #12386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Inphi
merged 4 commits into
ethereum-optimism:develop
from
zhiqiangxu:calling_convention
Oct 16, 2024
Merged
cannon: use constant instead of magic value #12386
Inphi
merged 4 commits into
ethereum-optimism:develop
from
zhiqiangxu:calling_convention
Oct 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ef1b5e to
35f5d25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12386 +/- ##
===========================================
- Coverage 64.32% 64.14% -0.19%
===========================================
Files 52 52
Lines 4348 4348
===========================================
- Hits 2797 2789 -8
- Misses 1376 1385 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mbaxter
reviewed
Oct 11, 2024
509fa7d to
9bdfb1c
Compare
9bdfb1c to
97f412b
Compare
Inphi
approved these changes
Oct 16, 2024
Contributor
Inphi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Thanks!
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* use constant instead of magic value * address comments * address comments * add RegSyscallErrno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
Gradually we should shift to these constant names and stop using magic numbers.