Configurable Dispute Game Parameters#12228
Merged
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Semgrep found 8
No Semgrep found 3
Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code. Ignore this finding from dangerous-exec-command. |
blmalone
force-pushed
the
10-01-configurable_dispute_game_parameters
branch
from
3831115 to
f1ce841
Compare
Base automatically changed from
10-01-configurable_gaslimit_for_op-deployer
to
develop
October 1, 2024 18:55
blmalone
force-pushed
the
10-01-configurable_dispute_game_parameters
branch
from
716802a to
8b248c9
Compare
blmalone
requested review from
mbaxter,
mds1,
mslipper and
protolambda
and removed request for
mbaxter and
protolambda
mds1
reviewed
Oct 1, 2024
mds1
reviewed
Oct 1, 2024
mds1
reviewed
Oct 1, 2024
mds1
reviewed
Oct 1, 2024
blmalone
force-pushed
the
10-01-configurable_dispute_game_parameters
branch
from
6082304 to
c26adcf
Compare
mds1
reviewed
Oct 2, 2024
mds1
approved these changes
Oct 2, 2024
blmalone
force-pushed
the
10-01-configurable_dispute_game_parameters
branch
from
aa21870 to
6fa9a8d
Compare
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Configurable Dispute Game Parameters * fix: more assertions for DeployOPChain.t.sol. * fix: running pre-pr command. * fix: changing dispute game types. * fix: semver lock file change. * fix: uint64 for maxGameDepth and splitDepth on go side. * fix: safe casting in solidity
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* Configurable Dispute Game Parameters * fix: more assertions for DeployOPChain.t.sol. * fix: running pre-pr command. * fix: changing dispute game types. * fix: semver lock file change. * fix: uint64 for maxGameDepth and splitDepth on go side. * fix: safe casting in solidity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all dispute game parameters, we should make them configurable via
op-deployer.