Skip to content

Conversation

@blmalone
Copy link
Contributor

@blmalone blmalone commented Oct 1, 2024

Gas limit should be configurable via op-deployer.

Copy link
Contributor Author

blmalone commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone marked this pull request as ready for review October 1, 2024 16:40
@blmalone blmalone requested review from a team as code owners October 1, 2024 16:40
@blmalone blmalone requested a review from mds1 October 1, 2024 16:57
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Oct 1, 2024

Semgrep found 8 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

Semgrep found 3 dangerous-exec-command findings:

Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code.

Ignore this finding from dangerous-exec-command.

@blmalone blmalone added this pull request to the merge queue Oct 1, 2024
Merged via the queue into develop with commit 7feffce Oct 1, 2024
@blmalone blmalone deleted the 10-01-configurable_gaslimit_for_op-deployer branch October 1, 2024 18:55
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* Configurable GasLimit for op-deployer

* fix: OPContractsManager.t.sol fixed.

* fix: OPContractsManagerInterop.sol

* fix: make gas limit configurable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants