Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helper for dumping fp-tests fixtures in op-program action tests #11855

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented Sep 11, 2024

Overview

Adds a helper function for dumping fp-tests formatted fixtures from the op-program action tests.

@clabby clabby requested review from a team as code owners September 11, 2024 22:25
@clabby clabby requested review from axelKingsley and removed request for a team September 11, 2024 22:25
Copy link
Member Author

clabby commented Sep 11, 2024

Copy link
Contributor

semgrep-app bot commented Sep 11, 2024

Semgrep found 8 sol-style-return-arg-fmt findings:

  • packages/contracts-bedrock/src/libraries/Constants.sol
  • packages/contracts-bedrock/src/L1/SystemConfig.sol
  • packages/contracts-bedrock/src/L1/OptimismPortal2.sol
  • packages/contracts-bedrock/src/L1/OptimismPortal.sol
  • packages/contracts-bedrock/scripts/interfaces/ISystemConfigV0.sol
  • packages/contracts-bedrock/scripts/DeploySuperchain.s.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

op-e2e/actions/op_program_test.go Outdated Show resolved Hide resolved
op-e2e/actions/op_program_test.go Show resolved Hide resolved
op-e2e/actions/op_program_test.go Show resolved Hide resolved
op-e2e/actions/op_program_test.go Show resolved Hide resolved
op-e2e/actions/op_program_test.go Outdated Show resolved Hide resolved
@clabby clabby requested a review from a team as a code owner September 11, 2024 23:34
@clabby clabby requested review from smartcontracts and removed request for a team September 11, 2024 23:34
@clabby clabby force-pushed the cl/program-action-fixture-dump branch from 5e56293 to e92a168 Compare September 11, 2024 23:34
@clabby clabby force-pushed the cl/program-action-fixture-dump branch from 01501f7 to efad023 Compare September 11, 2024 23:57
Base automatically changed from cl/action-test-op-program to develop September 12, 2024 00:08
@clabby clabby force-pushed the cl/program-action-fixture-dump branch from efad023 to d583a2e Compare September 12, 2024 00:32
@clabby clabby added this pull request to the merge queue Sep 12, 2024
Merged via the queue into develop with commit 320e11d Sep 12, 2024
61 checks passed
@clabby clabby deleted the cl/program-action-fixture-dump branch September 12, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants