-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Run op-program
in op-e2e
action tests
#11846
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Semgrep found 3 Named return arguments to functions must be appended with an underscore ( |
Semgrep found 5
Named return arguments to functions must be appended with an underscore ( |
79c2125
to
bb912b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think this would be that easy. Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think it's worth having a single method to run op-program and avoid duplicating boilerplate for that right from the start. The other comments are fine to leave for now but I'd like to have a play and see if we can clean things up, but probably not worth blocking this PR landing.
add0b86
to
e2ff930
Compare
Overview
Adds a notion of in-process data sources to the
op-program
configuration, and hooks up theop-program
to theop-e2e
action tests.This PR is preparation for generating test fixtures for fp-tests, using the
op-program
as a reference implementation, and taking advantage ofop-e2e
's action test suite for granular control over the chain that we're fault proving.