Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Run op-program in op-e2e action tests #11846

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

clabby
Copy link
Member

@clabby clabby commented Sep 11, 2024

Overview

Adds a notion of in-process data sources to the op-program configuration, and hooks up the op-program to the op-e2e action tests.

This PR is preparation for generating test fixtures for fp-tests, using the op-program as a reference implementation, and taking advantage of op-e2e's action test suite for granular control over the chain that we're fault proving.

Copy link
Member Author

clabby commented Sep 11, 2024

Copy link
Contributor

semgrep-app bot commented Sep 11, 2024

Semgrep found 3 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Copy link
Contributor

semgrep-app bot commented Sep 11, 2024

Semgrep found 5 sol-style-return-arg-fmt findings:

  • packages/contracts-bedrock/src/libraries/Constants.sol
  • packages/contracts-bedrock/src/L1/SystemConfig.sol
  • packages/contracts-bedrock/src/L1/OptimismPortal2.sol
  • packages/contracts-bedrock/src/L1/OptimismPortal.sol
  • packages/contracts-bedrock/scripts/interfaces/ISystemConfigV0.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

@clabby clabby marked this pull request as ready for review September 11, 2024 18:49
@clabby clabby requested review from a team as code owners September 11, 2024 18:49
@clabby clabby requested review from Inphi, axelKingsley and ajsutton and removed request for axelKingsley September 11, 2024 18:49
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think this would be that easy. Nice!

op-e2e/system_fpp_test.go Outdated Show resolved Hide resolved
op-e2e/actions/op_program_test.go Show resolved Hide resolved
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's worth having a single method to run op-program and avoid duplicating boilerplate for that right from the start. The other comments are fine to leave for now but I'd like to have a play and see if we can clean things up, but probably not worth blocking this PR landing.

op-e2e/actions/op_program_test.go Show resolved Hide resolved
op-e2e/actions/op_program_test.go Show resolved Hide resolved
op-program/host/sources/sources.go Show resolved Hide resolved
op-e2e/actions/op_program_test.go Show resolved Hide resolved
@clabby clabby added this pull request to the merge queue Sep 11, 2024
Merged via the queue into develop with commit 89c9fef Sep 12, 2024
60 checks passed
@clabby clabby deleted the cl/action-test-op-program branch September 12, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants