Skip to content

fix(ctb): kontrol snapshots #10557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mds1 merged 6 commits into from
May 15, 2024
Merged

fix(ctb): kontrol snapshots #10557

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ce698b
fix(ctb): snapshots
mds1 May 15, 2024
b205321
ci: fix snapshot check command to also consider kontrol
mds1 May 15, 2024
97f3194
ctb: Disable the LivenessModule after ownership is transferred to
maurelian May 14, 2024
e32a180
ctb: Update LM deactivation
maurelian May 14, 2024
1024a65
Merge pull request #10529 from ethereum-optimism/maur/lm-brick-on-fal…
maurelian May 15, 2024
961cb7c
Merge branch 'develop' into fix/snapshots
mds1 May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/contracts-bedrock/scripts/checks/check-snapshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ set -euo pipefail
# Generate the snapshots
pnpm snapshots

# Check if the generated snapshots are different from the committed snapshots
if git diff --exit-code snapshots > /dev/null; then
[ -z "$(git ls-files --others --exclude-standard snapshots)" ] || exit 1
# Check if the generated `snapshots` or `test/kontrol` files are different from the committed versions
if git diff --exit-code snapshots test/kontrol > /dev/null; then
[ -z "$(git ls-files --others --exclude-standard snapshots test/kontrol)" ] || exit 1
else
exit 1
fi
Comment thread
mds1 marked this conversation as resolved.
Loading