Skip to content

fix(ctb): kontrol snapshots#10557

Merged
mds1 merged 6 commits intodevelopfrom
fix/snapshots
May 15, 2024
Merged

fix(ctb): kontrol snapshots#10557
mds1 merged 6 commits intodevelopfrom
fix/snapshots

Conversation

@mds1
Copy link
Contributor

@mds1 mds1 commented May 15, 2024

In #10538 had the snapshots checks pass, even though they were not actually correct—they caused the kontrol proofs to fail. When I update snapshots locally, proofs pass again.

The reason snapshot checks incorrectly passed in that PR is because they only looked for diffs in the snapshots folder, but the kontrol snapshots are in a different folder. This PR fix that by updating the check-snapshots.sh script to also look at the test/kontrol folder

@mds1 mds1 requested a review from a team as a code owner May 15, 2024 19:01
@mds1 mds1 requested a review from refcell May 15, 2024 19:01
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

The changes encompass updating internal constant addresses within various Solidity files to ensure accurate assignments for proxy addresses, registry addresses, and other contract addresses, facilitating proper interactions in the blockchain network.

Changes

Files Change Summary
.../DeploymentSummary.sol Updated internal constant addresses for multiple proxies, registries, and related contracts.
.../DeploymentSummaryFaultProofs.sol Updated acc27Address; acc28Address remains unchanged.
.../checks/check-snapshots.sh Updated logic to check generated snapshots against committed versions, now includes test/kontrol.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mds1 mds1 enabled auto-merge May 15, 2024 19:06
@codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.22%. Comparing base (ca48ea7) to head (961cb7c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10557       +/-   ##
============================================
- Coverage    42.36%   29.22%   -13.15%     
============================================
  Files           73       31       -42     
  Lines         4836     2898     -1938     
  Branches       766      614      -152     
============================================
- Hits          2049      847     -1202     
+ Misses        2680     1976      -704     
+ Partials       107       75       -32     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests ?
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests ?
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

@mds1 mds1 disabled auto-merge May 15, 2024 19:14
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

maurelian and others added 3 commits May 15, 2024 16:16
fallback owner

ctb: Use deactivated flag

ctb: Update snapshots
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
…lback

      ctb: Disable the LivenessModule after ownership is transferred to fallback owner
Copy link
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mds1 and the rest of your teammates on Graphite Graphite

@mds1 mds1 enabled auto-merge May 15, 2024 20:49
@mds1 mds1 added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit e30ccc0 May 15, 2024
@mds1 mds1 deleted the fix/snapshots branch May 15, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants