Conversation
Prepares the `op-proposer` to no longer depend on the `op-bindings` package. This will enable releases of the `op-proposer` to work with specific releases of the contracts more easily by using `abigen` at a specific release of the contracts to create bindings. We will be gutting `op-bindings` as a package because it is not versioned, implying all versions must be backwards and forwards compatible. It also adds a lot of overhead to smart contract development with having to create the bindings and commit in a diff every time there is a solidity source file change.
Contributor
|
Warning Rate Limit Exceeded@tynes has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 32 minutes and 47 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
protolambda
approved these changes
Apr 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tynes
added a commit
that referenced
this pull request
Apr 19, 2024
Removes the `op-challenger` from requiring the global bindings. This allows the service to be explicit about contract versions that it supports. The `op-bindings` were not versioned and added a lot of pain when it came to smart contract development as they needed to always be updated. Follows: - #10213 - #10218
tynes
added a commit
that referenced
this pull request
Apr 19, 2024
Removes the dependency on the `op-bindings/bindings` package. This is to improve devex in the monorepo and reduce CI time as maintaining the bindings autogenerated in each PR just doesn't scale. Now each service is responsible for their own bindings. In the future, we can work towards releases of the bindings when contracts are released. Follows: - #10213 - #10218 - #10221
tynes
added a commit
that referenced
this pull request
Apr 23, 2024
Removes the dependency on the `op-bindings/bindings` package. This is to improve devex in the monorepo and reduce CI time as maintaining the bindings autogenerated in each PR just doesn't scale. Now each service is responsible for their own bindings. In the future, we can work towards releases of the bindings when contracts are released. Follows: - #10213 - #10218 - #10221
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* indexer: remove bindings Removes the dependency on the `op-bindings/bindings` package. This is to improve devex in the monorepo and reduce CI time as maintaining the bindings autogenerated in each PR just doesn't scale. Now each service is responsible for their own bindings. In the future, we can work towards releases of the bindings when contracts are released. Follows: - #10213 - #10218 - #10221 * indexer: add missing binding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepares the
op-proposerto no longer dependon the
op-bindingspackage. This will enablereleases of the
op-proposerto work with specificreleases of the contracts more easily by using
abigenat a specific release of the contracts to create bindings.
We will be gutting
op-bindingsas a package becauseit is not versioned, implying all versions must be backwards
and forwards compatible. It also adds a lot of overhead to
smart contract development with having to create the bindings
and commit in a diff every time there is a solidity source file
change.