op-node: remove dependency on bindings#10213
Conversation
Removes the `op-node` dependency on the `op-bindings/bindings` package. This moves `op-node` into a world where it relies completely on bindings that it generates itself. A `make` recipe could be useful for this in the future. This will enable us to say that the `op-node` is compatible with particular releases of the contracts. This change was made by searching for `"github.com/ethereum-optimism/optimism/op-bindings/bindings"` in the codebase and replacing it. There is still a dependency on `op-bindings/predeploys`, maybe we want to keep that around or put them in a different package.
tynes
requested review from
a team,
ajsutton,
protolambda and
trianglesphere
as code owners
|
Warning Rate Limit Exceeded@tynes has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 17 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on integrating new Ethereum contract bindings and refining import paths across various files in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10213 +/- ##
============================================
- Coverage 42.40% 29.22% -13.18%
============================================
Files 73 31 -42
Lines 4830 2898 -1932
Branches 766 614 -152
============================================
- Hits 2048 847 -1201
+ Misses 2676 1976 -700
+ Partials 106 75 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Removes the `op-challenger` from requiring the global bindings. This allows the service to be explicit about contract versions that it supports. The `op-bindings` were not versioned and added a lot of pain when it came to smart contract development as they needed to always be updated. Follows: - #10213 - #10218
Removes the dependency on the `op-bindings/bindings` package. This is to improve devex in the monorepo and reduce CI time as maintaining the bindings autogenerated in each PR just doesn't scale. Now each service is responsible for their own bindings. In the future, we can work towards releases of the bindings when contracts are released. Follows: - #10213 - #10218 - #10221
Removes the dependency on the `op-bindings/bindings` package. This is to improve devex in the monorepo and reduce CI time as maintaining the bindings autogenerated in each PR just doesn't scale. Now each service is responsible for their own bindings. In the future, we can work towards releases of the bindings when contracts are released. Follows: - #10213 - #10218 - #10221
* indexer: remove bindings Removes the dependency on the `op-bindings/bindings` package. This is to improve devex in the monorepo and reduce CI time as maintaining the bindings autogenerated in each PR just doesn't scale. Now each service is responsible for their own bindings. In the future, we can work towards releases of the bindings when contracts are released. Follows: - #10213 - #10218 - #10221 * indexer: add missing binding
3 participants
Description
Removes the
op-nodedependency on theop-bindings/bindingspackage. This moves
op-nodeinto a world where it reliescompletely on bindings that it generates itself. A
makerecipecould be useful for this in the future. This will enable us to say
that the
op-nodeis compatible with particular releases of thecontracts.
This change was made by searching for
"github.com/ethereum-optimism/optimism/op-bindings/bindings"in the codebase and replacing it.
There is still a dependency on
op-bindings/predeploys, maybewe want to keep that around or put them in a different package.