Skip to content

Docs improvements#776

Merged
cpengilly merged 6 commits intoethereum-optimism:mainfrom
nnsW3:docs-improvements
Jun 28, 2024
Merged

Docs improvements#776
cpengilly merged 6 commits intoethereum-optimism:mainfrom
nnsW3:docs-improvements

Conversation

@nnsW3
Copy link
Contributor

@nnsW3 nnsW3 commented Jun 28, 2024

Rectify typographical inaccuracies

This PR addresses several typographical errors across various files in the project. The changes improve readability and maintain the professional standard of the documentation and code comments.

Justification
Typographical errors, while minor, can detract from the overall quality of the project. Correcting these errors ensures clarity and professionalism, making the project more accessible and understandable for current and future contributors.

@nnsW3 nnsW3 requested a review from a team as a code owner June 28, 2024 12:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 28, 2024

Walkthrough

These changes involve minor textual adjustments for clarity and correctness across various documentation files. The modifications include wording improvements, tense corrections, and minor semantic shifts. No changes have been made to the logic, control flow, or declarations of exported or public entities in the affected files.

Changes

File Path Change Summary
notes/actions.md Adjusted sentence wording for improved clarity.
notes/content-reuse.md Corrected the heading for clarity in a section about reusable content components.
pages/builders/app-developers/bridging/standard-bridge.mdx Modified the description of token storage semantics from "are stored" to "is stored."
pages/builders/app-developers/contracts/optimization.mdx Corrected the tense of a statement about the L1 Data Fee on OP Mainnet.
pages/builders/notices/fp-changes.mdx Replaced "reproven" with "reprovened" in a notice about withdrawals before and after a Fault Proofs upgrade.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 316770e
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/667eee993c5be20008a992b4
😎 Deploy Preview https://deploy-preview-776--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Outside diff range and nitpick comments (9)
notes/actions.md (1)

Line range hint 6-6: Consider using "execute" instead of "run" for a more formal tone.

This change aligns with the suggestion from the static analysis tool to use a more formal verb, enhancing the professional tone of the documentation.

- Run `pnpm lint` to lint locally and run `pnpm fix` to fix issues that the linter can fix automatically.
+ Execute `pnpm lint` to lint locally and execute `pnpm fix` to fix issues that the linter can fix automatically.
notes/content-reuse.md (2)

Line range hint 15-15: Add the missing article "the".

The static analysis tool correctly identified missing articles before .mdx which can improve the readability and correctness of the documentation.

- Import it at the top of `.mdx` file:
+ Import it at the top of the `.mdx` file:

- Import it at the top of `.mdx` file:
+ Import it at the top of the `.mdx` file:

Also applies to: 41-41

Tools
Markdownlint

33-33: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


Line range hint 17-17: Specify language for code blocks.

To improve syntax highlighting and readability, specify the language for the code blocks.

- ```
+ ```javascript
- ```
+ ```javascript
- ```
+ ```javascript
- ```
+ ```javascript

Also applies to: 23-23, 36-36, 43-43

Tools
Markdownlint

33-33: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)

pages/builders/app-developers/contracts/optimization.mdx (1)

Line range hint 17-17: Add a comma for clarity.

Adding a comma can improve the readability of complex sentences.

- By the end of this guide you should have a clear understanding of how OP Mainnet contracts can be optimized and whether or not these optimizations make sense for your application.
+ By the end of this guide, you should have a clear understanding of how OP Mainnet contracts can be optimized and whether these optimizations make sense for your application.
Tools
LanguageTool

[style] ~32-~32: Try using a synonym here to elevate your writing.
Context: ...his guide was written, this L1 Data Fee made up the majority of the cost of most transa...

(CONSTITUTE_COMPRISE)


[style] ~34-~34: Consider a shorter alternative to avoid wordiness.
Context: ...ng the amount of storage/execution used in order to decrease the amount of user-provided da...

(IN_ORDER_TO_PREMIUM)


[style] ~35-~35: Did you mean ‘different from’? ‘Different than’ is often considered colloquial style.
Context: ...ontract optimization slightly different than on Ethereum. ## Considerations ### Ad...

(DIFFERENT_THAN)

pages/builders/notices/fp-changes.mdx (2)

Line range hint 45-45: Add the missing article "the".

Including the article "the" before "Most notable change" improves grammatical correctness.

- Most notable change for developers is that withdrawals will have to be proven against the `rootClaim` of some dispute game rather than referencing an output in the `L2OutputOracle` contract.
+ The most notable change for developers is that withdrawals will have to be proven against the `rootClaim` of some dispute game rather than referencing an output in the `L2OutputOracle` contract.
Tools
LanguageTool

[style] ~21-~21: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...thdrawal-flow) again. * Withdrawals prior to the Fault Proofs upgrade must wait a 7-...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


Line range hint 46-46: Add a comma for clarity.

Inserting a comma can help break up a long sentence and improve readability.

- Most notable change for developers is that withdrawals will have to be proven against the `rootClaim` of some dispute game rather than referencing an output in the `L2OutputOracle` contract.
+ Most notable change for developers is that withdrawals will have to be proven against the `rootClaim` of some dispute game, rather than referencing an output in the `L2OutputOracle` contract.
Tools
LanguageTool

[style] ~21-~21: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...thdrawal-flow) again. * Withdrawals prior to the Fault Proofs upgrade must wait a 7-...

(EN_WORDINESS_PREMIUM_PRIOR_TO)

pages/builders/app-developers/bridging/standard-bridge.mdx (3)

Line range hint 13-13: Use an en dash for numerical ranges.

Replacing the hyphen with an en dash in numerical ranges follows typographical best practices.

- Transfers from Ethereum to OP Mainnet via the Standard Bridge are usually completed within 1-3 minutes.
+ Transfers from Ethereum to OP Mainnet via the Standard Bridge are usually completed within 1–3 minutes.
Tools
LanguageTool

[style] ~89-~89: This phrase is redundant. Consider using “inside”.
Context: ...s from the user's address and lock them inside of the bridge contract. A record of all ...

(OUTSIDE_OF)


Line range hint 45-45: Clarify the use of "use to".

The phrase "use to" should be changed to "used to" to correctly indicate past habitual actions.

- All bridged versions of tokens must implement this interface to be used with the `StandardBridge`.
+ All bridged versions of tokens must have implemented this interface to be used with the `StandardBridge`.
Tools
LanguageTool

[style] ~89-~89: This phrase is redundant. Consider using “inside”.
Context: ...s from the user's address and lock them inside of the bridge contract. A record of all ...

(OUTSIDE_OF)


Line range hint 63-63: Simplify the phrase for clarity.

Simplifying phrases can enhance readability and comprehension.

- To do this, the user must first give the bridge an allowance to transfer the number of tokens that the user wishes to convert into a bridged representation.
+ To do this, the user must first grant the bridge an allowance to transfer the desired number of tokens for conversion.
Tools
LanguageTool

[style] ~89-~89: This phrase is redundant. Consider using “inside”.
Context: ...s from the user's address and lock them inside of the bridge contract. A record of all ...

(OUTSIDE_OF)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants