build(deps): bump actions/upload-artifact from 6 to 7#7339
Merged
JohnMcLear merged 1 commit intodevelopfrom Mar 13, 2026
Merged
build(deps): bump actions/upload-artifact from 6 to 7#7339JohnMcLear merged 1 commit intodevelopfrom
JohnMcLear merged 1 commit intodevelopfrom
Conversation
dependabot
Bot
added
dependencies
Member
|
/review |
Code Review by Qodo
1. matrix.node referenced without matrix
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Comment on lines
+72
to
75
| - uses: actions/upload-artifact@v7 | ||
| if: always() | ||
| with: | ||
| name: playwright-report-${{ matrix.node }}-chrome |
There was a problem hiding this comment.
1. Matrix.node referenced without matrix 🐞 Bug ✓ Correctness
frontend-tests.yml uses ${{ matrix.node }} in artifact names, but none of the jobs define a
strategy.matrix, so the workflow will fail expression evaluation or generate incorrect artifact
names. This affects all three Playwright jobs and can cause the artifact upload step (and job) to
fail even when tests otherwise run.
Agent Prompt
### Issue description
`frontend-tests.yml` uses `${{ matrix.node }}` in artifact names, but the workflow does not define a `strategy.matrix` anywhere in those jobs. This can break the workflow due to an undefined expression context.
### Issue Context
- `frontend-admin-tests.yml` correctly defines `strategy.matrix.node` before using `${{ matrix.node }}`.
- `frontend-tests.yml` has three jobs (chrome/firefox/webkit) that use `${{ matrix.node }}` but have no matrix.
### Fix Focus Areas
- .github/workflows/frontend-tests.yml[12-18]
- .github/workflows/frontend-tests.yml[72-77]
- .github/workflows/frontend-tests.yml[132-137]
- .github/workflows/frontend-tests.yml[196-201]
### Suggested change
Pick one:
1) **Remove** `matrix.node` from the artifact `name` fields (replace with `${{ github.job }}` or `playwright-report-chrome|firefox|webkit`).
2) **Add** `strategy.matrix.node: [...]` to each job and also add/use a node setup step so `matrix.node` is meaningful.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Member
|
@dependabot recreate |
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/actions/upload-artifact-7
branch
from
6a8406d to
c3f3458
Compare
JohnMcLear
deleted the
dependabot/github_actions/actions/upload-artifact-7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 6 to 7.
Release notes
Sourced from actions/upload-artifact's releases.
Commits
bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)