Skip to content

build(deps): bump actions/upload-artifact from 6 to 7 #7339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
Mar 13, 2026
Merged

build(deps): bump actions/upload-artifact from 6 to 7 #7339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/frontend-admin-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:
gnpm exec playwright install --runtimeVersion="${{ matrix.node }}"
gnpm exec playwright install-deps --runtimeVersion="${{ matrix.node }}"
gnpm run test-admin --runtimeVersion="${{ matrix.node }}"
- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@v7
if: always()
with:
name: playwright-report-${{ matrix.node }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/frontend-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
cd src
gnpm exec playwright install chromium --with-deps
gnpm run test-ui --project=chromium
- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@v7
if: always()
with:
name: playwright-report-${{ matrix.node }}-chrome
Comment on lines +72 to 75
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Matrix.node referenced without matrix 🐞 Bug ✓ Correctness

frontend-tests.yml uses ${{ matrix.node }} in artifact names, but none of the jobs define a
strategy.matrix, so the workflow will fail expression evaluation or generate incorrect artifact
names. This affects all three Playwright jobs and can cause the artifact upload step (and job) to
fail even when tests otherwise run.
Agent Prompt 
### Issue description
`frontend-tests.yml` uses `${{ matrix.node }}` in artifact names, but the workflow does not define a `strategy.matrix` anywhere in those jobs. This can break the workflow due to an undefined expression context.

### Issue Context
- `frontend-admin-tests.yml` correctly defines `strategy.matrix.node` before using `${{ matrix.node }}`.
- `frontend-tests.yml` has three jobs (chrome/firefox/webkit) that use `${{ matrix.node }}` but have no matrix.

### Fix Focus Areas
- .github/workflows/frontend-tests.yml[12-18]
- .github/workflows/frontend-tests.yml[72-77]
- .github/workflows/frontend-tests.yml[132-137]
- .github/workflows/frontend-tests.yml[196-201]

### Suggested change
Pick one:
1) **Remove** `matrix.node` from the artifact `name` fields (replace with `${{ github.job }}` or `playwright-report-chrome|firefox|webkit`).
2) **Add** `strategy.matrix.node: [...]` to each job and also add/use a node setup step so `matrix.node` is meaningful.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
cd src
gnpm exec playwright install firefox --with-deps
gnpm run test-ui --project=firefox
- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@v7
if: always()
with:
name: playwright-report-${{ matrix.node }}-firefox
Expand Down Expand Up @@ -193,7 +193,7 @@ jobs:
cd src
gnpm exec playwright install webkit --with-deps
gnpm run test-ui --project=webkit || true
- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@v7
if: always()
with:
name: playwright-report-${{ matrix.node }}-webkit
Expand Down
Loading