(de)indent behaviour enhancement

[yadutaf]

Hi again !

This is the next part of the "fix". I added support for text indentation via unordered list with no bullets to be less intrusive.
When indenting/de-indenting text/lists, relative indentation between items is preserved, unless going to the lowest indentation level.
It is possible to "toggle" list while preserving the indentation of the text. This is basically done by converting between the two list types.

I'm open to suggestions to make it even better before inclusion :)

[JohnMcLear]

Can someone please test this?

[yadutaf]

If you want, you can try it directly on my dev version : http://www.jtlebi.fr:6001/p/test Please, note that it is not my production version :)

[JohnMcLear]

I don't like the behavior if you type a few words then press tab it indents the line.

Imho a tab is a tab, it's only an indent if you are at the beginning of the line.

[randyho-kk]

agree. that behavior goes counter to traditional tab use

[yadutaf]

Hi !

Thanks for your feedback. Is that more like what you expect with this fix ?
The URL above has been updated with the latest dev version.

[randyho-kk]

this update now works and matches traditional word processing shift-tab behavior.

good job @jtlebi.

looks good to pull from my end.

[yadutaf]

I just fixed a very weird bug you probably noticed. When appending a char to an indented line, it was automatically turned into a bullet list. This actually was caused by "bullet" being hardcoded somewhere into contentcollector.js. The fix replaces it with a regular expression just as it is done in ace2_inner.js

[Pita]

@johnyma22 please decide about this pull request

[Pita]

bump, @johnyma22 please decide about this pull request

[JohnMcLear]

Yep, good to pull.

[Wikinaut]

Please reopen this bug.

Reason: there is the remaining problem, that TAB in a line after some characters works (indents),
but SHIFT-TAB does not de-indent but indents, too.

TABsomecharactersTAB2 TAB3..

SHIFT-TAB after TAB2 does not work, and is executed as TAB3 instead, which is wrong and unexpected behaviour.

[randyho-kk]

disagree with @Wikinaut.

The behavior is true to traditional text editors.

I tried shift-tab in Notepad, MS Word, and vim.

All will remove the tab on shift-tab only if the cursor is at the beginning of the line.

All will add a tab on shift-tab if there are any characters to the left of the cursor.

to delete a tab in the middle of a line, you can use the backspace key.

I do not support reopening.

[yadutaf]

Anyway, this is not very complicated to change this behavior. It is true that it may not be a very intuitive action. Actually, I was aiming at doing what @Wikinaut suggested in the Week-End.

[randyho-kk]

what will the behavior of shift-tab be in cases like this:

\char\char\space\cursor\char

does it remove the space, add a tab, or do nothing?

[Wikinaut]

@KingKaeru
what will the behavior of shift-tab be in cases like this:

\char\char\space\cursor\char

does it remove the space, add a tab, or do nothing?

-> do nothing.

A single Shift-TAB click should, in my expectation, only revert a single TAB left of the current cursor position.

[Wikinaut]

Related to issue https://github.com/Pita/etherpad-lite/issues/173 "shift tab should de-indent instead of indenting"

[JohnMcLear]

Thanks Randy, that is very informative.

-----Original Message-----
From: Randy [mailto:[email protected]]
Sent: 01 December 2011 19:13
To: John McLear
Subject: Re: etherpad-liteindent behaviour enhancement (#231)

disagree with @Wikinaut.

The behavior is true to traditional text editors.

I tried shift-tab in Notepad, MS Word, and vim.

All will remove the tab on shift-tab only if the cursor is at the beginning of the line.

All will add a tab on shift-tab if there are any characters to the left of the cursor.

I do not support reopening.

---

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/231#issuecomment-2979034
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

[randyho-kk]

i think traditionally, text editors don't remove a tab mid line on a shift-tab because of cases where people are doing something like this:

<hold shift> ABC<tab>EFG<tab>HIJ<tab>KLM<release shift>

allows for quick adding of tab while typing caps without having to release shift.

i can't ever imagine using shift-tab other than when i am tab indenting at the beginning of a line. If i tab in the middle of a line, i always just use backspace to remove.

[Wikinaut]

I fully agree with you, I have never used Shift-TAB in my life.

[Pita]

+1 "I fully agree with you, I have never used Shift-TAB in my life."

[Pita]

I feel like here is a large discussion about a feature nearly nobody cares about