Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"stuck" on "Loading" page #224

Closed
markreg opened this issue Nov 22, 2011 · 53 comments
Closed

"stuck" on "Loading" page #224

markreg opened this issue Nov 22, 2011 · 53 comments

Comments

@markreg
Copy link

markreg commented Nov 22, 2011

Output from the server:

[2011-11-22 16:11:55.605] [INFO] console - Your Etherpad Lite git version is 2db8105
[2011-11-22 16:11:55.607] [INFO] console - Report bugs at https://github.com/Pita/etherpad-lite/issues
[2011-11-22 16:11:55.778] [INFO] console - Server is listening at 0.0.0.0:9001
[2011-11-22 16:11:55.780] [INFO] console - info - 'socket.io started'
[2011-11-22 16:11:58.478] [INFO] http - 200, GET /p/Y9Z81HxiJm
[2011-11-22 16:11:59.555] [INFO] socket.io - handshake authorized '17076206631540154799'
[2011-11-22 16:12:09.273] [INFO] http - 200, GET /p/Session
[2011-11-22 16:12:09.842] [INFO] socket.io - handshake authorized '8602402112052001713'
[2011-11-22 16:12:20.548] [INFO] socket.io - transport end
[2011-11-22 16:13:54.303] [INFO] socket.io - transport end
[2011-11-22 16:13:54.385] [ERROR] console - CLIENT SIDE JAVASCRIPT ERROR: {"msg":"Error loading script","url":"http://localhost:9001/socket.io/1/jsonp-polling/8602402112052001713?t=1322003628473&i=0","linenumber":1,"userAgent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0"}
[2011-11-22 16:13:54.385] [INFO] http - 200, POST /jserror
[2011-11-22 16:13:54.391] [INFO] http - 304, GET /p/Session
[2011-11-22 16:13:54.497] [INFO] http - 304, GET /static/css/pad.css
[2011-11-22 16:13:54.587] [INFO] http - 304, GET /static/custom/pad.css
[2011-11-22 16:13:55.764] [INFO] http - 304, GET /static/custom/pad.js
[2011-11-22 16:13:55.765] [INFO] http - 304, GET /p/Session
[2011-11-22 16:14:06.984] [INFO] http - 304, GET /p/Session
[2011-11-22 16:14:06.984] [INFO] http - 304, GET /p/Session
[2011-11-22 16:14:06.989] [INFO] http - 200, GET /p/Session
[2011-11-22 16:14:07.239] [INFO] http - 200, GET /static/custom/pad.css
[2011-11-22 16:14:07.241] [INFO] http - 200, GET /static/custom/pad.js
[2011-11-22 16:14:07.326] [INFO] http - 200, GET /p/Session
[2011-11-22 16:14:07.491] [INFO] http - 200, GET /static/css/pad.css
[2011-11-22 16:14:07.969] [INFO] http - 200, GET /minified/pad.js
[2011-11-22 16:14:08.350] [INFO] socket.io - handshake authorized '12814689401664151200'
[2011-11-22 16:14:08.352] [INFO] http - 200, GET /static/img/loading.gif
[2011-11-22 16:14:08.352] [INFO] http - 200, GET /static/img/leftarrow.png
[2011-11-22 16:14:08.354] [INFO] http - 200, GET /static/img/etherpad_lite_icons.png
[2011-11-22 16:15:10.870] [INFO] socket.io - handshake authorized '1315621722183686826'
[2011-11-22 16:15:26.590] [INFO] socket.io - handshake authorized '18885323151886586089'
[2011-11-22 16:15:46.306] [INFO] socket.io - transport end
[2011-11-22 16:15:46.892] [INFO] socket.io - handshake authorized '15656086571427261589'
[2011-11-22 16:15:57.890] [INFO] socket.io - handshake authorized '1517462598504470842'
[2011-11-22 16:16:01.757] [INFO] socket.io - transport end
[2011-11-22 16:16:01.892] [INFO] socket.io - handshake authorized '1010530881398101965'
[2011-11-22 16:16:12.340] [INFO] socket.io - handshake authorized '1436364354846802906'
[2011-11-22 16:16:21.841] [INFO] socket.io - transport end
[2011-11-22 16:16:21.891] [INFO] socket.io - handshake authorized '1911975752963537353'
[2011-11-22 16:16:22.059] [INFO] socket.io - transport end
[2011-11-22 16:16:22.347] [INFO] socket.io - handshake authorized '12068730911951072905'
[2011-11-22 16:16:32.591] [INFO] socket.io - handshake authorized '838177011930131707'
[2011-11-22 16:16:32.681] [INFO] socket.io - handshake authorized '11060044691781968104'
[2011-11-22 16:16:37.059] [INFO] socket.io - transport end
[2011-11-22 16:16:37.344] [INFO] socket.io - handshake authorized '20409469851233928104'
[2011-11-22 16:16:42.148] [INFO] socket.io - transport end
[2011-11-22 16:16:42.344] [INFO] socket.io - handshake authorized '15495542341278541409'
[2011-11-22 16:16:42.894] [INFO] socket.io - handshake authorized '21112127631096345562'
[2011-11-22 16:16:47.507] [INFO] socket.io - transport end
[2011-11-22 16:16:47.596] [INFO] socket.io - handshake authorized '352222138360908464'
[2011-11-22 16:16:47.717] [INFO] socket.io - handshake authorized '1254756880525740093'
[2011-11-22 16:16:47.723] [INFO] socket.io - handshake authorized '907035159755920289'
[2011-11-22 16:16:52.645] [INFO] socket.io - handshake authorized '1404301442703982115'
[2011-11-22 16:16:52.651] [INFO] socket.io - handshake authorized '18843313321267050994'
[2011-11-22 16:16:57.140] [INFO] socket.io - transport end
[2011-11-22 16:16:57.348] [INFO] socket.io - handshake authorized '315609965850451540'
[2011-11-22 16:16:57.514] [INFO] socket.io - transport end
[2011-11-22 16:16:57.643] [INFO] socket.io - handshake authorized '3833772171929311716'
[2011-11-22 16:16:57.895] [INFO] socket.io - handshake authorized '6252445231033992425'
[2011-11-22 16:17:02.893] [INFO] socket.io - handshake authorized '918487734314263169'
[2011-11-22 16:17:07.592] [INFO] socket.io - transport end
[2011-11-22 16:17:07.650] [INFO] socket.io - handshake authorized '7280345971251234204'
[2011-11-22 16:17:07.654] [INFO] socket.io - handshake authorized '1580211153794212'
[2011-11-22 16:17:07.836] [INFO] socket.io - transport end
[2011-11-22 16:17:08.101] [INFO] socket.io - handshake authorized '4582640641110936735'
[2011-11-22 16:17:08.102] [INFO] socket.io - handshake authorized '10331474711070142302'

It just stays stuck on "Loading".

@markreg
Copy link
Author

markreg commented Nov 22, 2011

It just seems really slow...

@JohnMcLear
Copy link
Member

Anything on the client?

@markreg
Copy link
Author

markreg commented Nov 22, 2011

I get the main page to create a new pad and once I click on "New Pad" it takes me to the etherpad-lite interface then it says "Loading" on the interface for a long time...after about 8 minutes it loads everything but when I type in the client it doesn't update anything on the server and then the client says it needs to reconnect to the server.

If it helps...I installed etherpad-lite in a slightly non conventional way on a host that has restricted access to yum therefore I had to install each package manually. But installDeps.sh doesn't give me any errors other than:

npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']
npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']

@aicm
Copy link

aicm commented Nov 23, 2011

I can confirm this. Having the same issue on a normal install. I did not wait 8 minutes, but I usually have to restart etherpad to make it responsive again.

I'm currently proxying it via apche, but even directly (on 9001) it behaves the same.

@markreg
Copy link
Author

markreg commented Nov 23, 2011

Yeah I can't do anything to fix it...tried reinstalling eeverythign from scratch and still the same problem.

@phrozen77
Copy link

I've solved it with setting proxy_buffering off; in the vhost conf (location /) - try and see if it helps

(all assuming you're reverse proxying to nginx)

@aicm
Copy link

aicm commented Nov 24, 2011

That's great! I'm glad to hear that. I'll try to implement that setting in my apache config as well, just in case.

However, my issue is there even when accessing etherpad-lite itself on port 90001 (which shouldn't have anything to do with my apache reverse proxy config).

@markreg
Copy link
Author

markreg commented Nov 25, 2011

I'm not even using apache in the loop. This is the same problem as aicm with connecting to etherpad-lite directly on port 9001.

I have come to the conclusion that there is something wrong with my socket.io not receiving data from the client of visa-versa after trying out many different socket.io applications with node. It's almost like it's stuck. Unfortunately I'm not getting much help on socket.io's github or google groups.

@JohnMcLear
Copy link
Member

Try grabbing a version of etherpad-lite from a few weeks ago, do you have the same problem?

@markreg
Copy link
Author

markreg commented Nov 25, 2011

How can I download an older version?

@JohnMcLear
Copy link
Member

https://github.com/Pita/etherpad-lite/zipball/1.0

is from August.

-----Original Message-----
From: markreg [mailto:[email protected]]
Sent: 25 November 2011 01:12
To: John McLear
Subject: Re: [etherpad-lite] "stuck" on "Loading" page (#224)

How can I download an older version?


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/224#issuecomment-2870519
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

@markreg
Copy link
Author

markreg commented Nov 25, 2011

It says I need to downgrade my version of node to 0.4.x. Should I do so?

@JohnMcLear
Copy link
Member

Yep, worth a shot.

-----Original Message-----
From: markreg [mailto:[email protected]]
Sent: 25 November 2011 01:39
To: John McLear
Subject: Re: [etherpad-lite] "stuck" on "Loading" page (#224)

It says I need to downgrade my version of node to 0.4.x. Should I do so?


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/224#issuecomment-2870623
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

@soul9
Copy link
Contributor

soul9 commented Nov 25, 2011

same issue here, a commit between now and about two weeks ago causes this issue. I have proxy_buffering set to off in nginx.
Last revision that works properly for me is 53bf7dc , so the bug was introduced right at the next commit, saying 2e79bd5 : fixed socket.io logging
Thanks

@aicm
Copy link

aicm commented Nov 25, 2011

Okay, it has to be before fb158d2 because I had this issue then as well.

@soul9
Copy link
Contributor

soul9 commented Nov 25, 2011

please try with revision 53bf7dc that's the last one that worked for me.

@aicm
Copy link

aicm commented Nov 25, 2011

Okay, I have 53bf7dc up and running. Now that I read the "fixed: socket.io logging" I think I know what the issue is: Whenever you start etherpad by doing bin/run.sh & and then your ssh connection times out, etherpad freezes. Do you think there's a possibility that this is related to console not having a way to output to a connected "head"?

I ran the latest code by doing bin/run.sh > logme.log & and it hasn't gone freezing on me for 2 days now (with usage).

@soul9
Copy link
Contributor

soul9 commented Nov 25, 2011

uh, should this be an issue with safeRun.sh aswell? because safeRUN.sh does redirect stdout and stderr...I use safeRun.sh and still get the same error.

@aicm
Copy link

aicm commented Nov 25, 2011

Wish I had an answer for you. In theory it shouldn't be since it's the script that can be used in a cron.

@riseuplabs
Copy link

I have this same issue as well, I am running fine with 2cc7dcb. The proxy_buffering off; nginx tip is a red herring, I have that enabled, but if I update to nodejs 1.7 and the latest npm, and I update to the latest git version (043ceac) things fail as reported in this bug. It also has nothing to do with the run.sh/safeRun.sh.

My logs fill up pretty fast with the repeated:

[WARN] socket.io - client not handshaken 'client should reconnect'
[INFO] socket.io - transport end

@riseuplabs
Copy link

Some additional information, from startup:

Ensure that all dependencies are up to date...
npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']
npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']
[email protected] ./node_modules/async
[email protected] ./node_modules/gzip
[email protected] ./node_modules/log4js
[email protected] ./node_modules/uglify-js
[email protected] ./node_modules/formidable
[email protected] ./node_modules/clean-css
└── [email protected]
[email protected] ./node_modules/ueberDB
├── [email protected]
├── [email protected]
└── [email protected]
[email protected] ./node_modules/socket.io
├── [email protected]
├── [email protected]
└── [email protected]
[email protected] ./node_modules/express
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]
[email protected] ./node_modules/joose
├── [email protected]
├── [email protected] ([email protected])
└── [email protected]
Ensure jQuery is downloaded and up to date...
[: 57: =: unexpected operator
Clear minfified cache...
ensure custom css/js files are created...
start...
[2011-11-25 10:10:25.447] [INFO] console - ESC[39mYour Etherpad Lite git version is 043ceac

@riseuplabs
Copy link

I've just confirmed, 53bf7dc does work, and 2e79bd5 is where the issue occurs.

riseuplabs pushed a commit to riseuplabs/etherpad-lite that referenced this issue Nov 25, 2011
@markreg
Copy link
Author

markreg commented Nov 25, 2011

I get these errors when I run sh installDeps.sh and sh run.sh:

npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']
npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']

@JohnMcLear
Copy link
Member

That's not an error, that's a warning. There is already an open issue for this.

-----Original Message-----
From: markreg [mailto:[email protected]]
Sent: 25 November 2011 18:49
To: John McLear
Subject: Re: [etherpad-lite] "stuck" on "Loading" page (#224)

I get these errors when I run sh installDeps.sh:

npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url'] npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/224#issuecomment-2877168
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

@markreg
Copy link
Author

markreg commented Nov 25, 2011

Wow, problem seems to be solved with riseuplab's latest etherpad-lite build.

On a side note is there anything that I can do to increase the update speed on all of the other clients' windows?

@markreg markreg closed this as completed Nov 25, 2011
@markreg markreg reopened this Nov 25, 2011
@riseuplabs
Copy link

Wow, thanks for the quick resolution on this!

@Pita Pita closed this as completed Nov 26, 2011
@Pita
Copy link
Contributor

Pita commented Nov 26, 2011

I closed this

@Frankstar
Copy link

i have the issue with the current master and latest node

@Frankstar
Copy link

but have this issues too:

[ERROR] console - CLIENT SIDE JAVASCRIPT ERROR: {"msg":"isAndroid is not defined","url":"http://localhost:9001/minified/pad.js","linenumber":1,"userAgent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1"}

ERROR] console - CLIENT SIDE JAVASCRIPT ERROR: {"msg":"$("#colorpicker").farbtastic is not a function","url":"http://localhost:9001/minified/pad.js","linenumber":1,"userAgent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1"}

[ERROR] console - CLIENT SIDE JAVASCRIPT ERROR: {"msg":"chat is undefined","url":"http://localhost:9001/minified/pad.js","linenumber":1,"userAgent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1"}

@JohnMcLear
Copy link
Member

When did you last do a pull?

-----Original Message-----
From: Frankstar [mailto:[email protected]]
Sent: 22 January 2012 15:11
To: John McLear
Subject: Re: [etherpad-lite] "stuck" on "Loading" page (#224)

but have this issues too:

[ERROR] console - CLIENT SIDE JAVASCRIPT ERROR: {"msg":"isAndroid is not defined","url":"http://frankstar.at:9001/minified/pad.js","linenumber":1,"userAgent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1"}

ERROR] console - CLIENT SIDE JAVASCRIPT ERROR: {"msg":"$("#colorpicker").farbtastic is not a function","url":"http://frankstar.at:9001/minified/pad.js","linenumber":1,"userAgent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1"}

[ERROR] console - CLIENT SIDE JAVASCRIPT ERROR: {"msg":"chat is undefined","url":"http://frankstar.at:9001/minified/pad.js","linenumber":1,"userAgent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1"}


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/224#issuecomment-3603484
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

@Pita
Copy link
Contributor

Pita commented Jan 22, 2012

@aicm Thats fixed already

@Frankstar
Copy link

commit 04d48e8
Author: John McLear [email protected]
Date: Sun Jan 22 16:29:51 2012 +0000

Added a getting started developing Etherpad Lite video to readme.md..

commit ca68196
Author: John McLear [email protected]
Date: Sun Jan 22 16:24:06 2012 +0000

Added a getting started developing Etherpad Lite video to readme.md

commit cf47153
Merge: cece2c8 165f269
Author: Peter 'Pita' Martischka [email protected]
Date: Sun Jan 22 15:25:50 2012 +0100

doesnt work,

Output console:
npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']
npm WARN [email protected] package.json: bugs['web'] should probably be bugs['url']
npm WARN prefer global [email protected] should be installed with -g

maybe this are the problems ?

also the Errors from above are still showing.

@Frankstar
Copy link

weird, now it works .... something is strange here ...

@Pita
Copy link
Contributor

Pita commented Jan 22, 2012

You might just had a bad browser cache

On 22 January 2012 17:54, Frankstar
[email protected]
wrote:

weird, now it works .... something is strange here ...


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/224#issuecomment-3604096

@mitfik
Copy link

mitfik commented May 6, 2012

I've got the same problem right now with latest version.

When I try to get access to etherpad throught nginx it stuck on Loading
When I add port :9001 to domain it load without problem.

Any suggestion what could be a problem ?

Edit:
I figure out that the problem was that I didn't use https when I add cert to nginx all work fine.
Why it does not work without cert ?

@JohnMcLear
Copy link
Member

Latest stable or develop?

Robert Mitwicki [email protected] wrote:

I've got the same problem right now with latest version.

When I try to get access to etherpad throught nginx it stuck on Loading
When I add port :9001 to domain it load without problem.

Any suggestion what could be a problem ?


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/224#issuecomment-5538098
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

@mitfik
Copy link

mitfik commented May 6, 2012

latest develop (master branch)

@JohnMcLear
Copy link
Member

Pretty sure this is a new issue. I noticed this occur on beta.etherpad.org yesterday too. The develop branch is unstable. If you can catch the full stack trace that shows the error on the server that would be useful

@ferrix
Copy link

ferrix commented Feb 15, 2013

I noticed that an unrotated logfile had bloated and that rendered node slow.

@JohnMcLear
Copy link
Member

@ferrix Ah, that is possible. I think the Etherpad init script does log rotation on restart.

Also #253

As far as I can tell because we use log4js we should have log rotation so you shouldn't have this problem on newer versions of etherpad.

@marcelklehr
Copy link
Contributor

@ferrix
Copy link

ferrix commented Feb 15, 2013

I did a pull to a more recent version so the problem should be gone.

@brauliobo
Copy link

I also feel this slowness... It takes a lot of time for a pad to load. I'm using the version 1.3.0

@JohnMcLear
Copy link
Member

@brauliobo Did you find a cause? Have you tried pulling the latest develop?

@brauliobo
Copy link

@JohnMcLear hello john. No, I haven't. We initially used develop branch at pad.eita.org.br, but now we downgraded to 1.3.0.

I currently live on the coutryside of Brazil and have a slow connection, less than 1mb/s. But etherpad-lite takes much more time than usual pages...

@JohnMcLear
Copy link
Member

Sorry but we'd need more info.

pad.eita.org.br pads work fine for me, it's very fast.

Can you provide benchmark or stats or so?

@brauliobo
Copy link

@JohnMcLear Ok, john, I'll try to debug more on developers tools

@marcelklehr
Copy link
Contributor

That may just be because etherpad is not just a usual page.

How long does it take to load, exactly? (Anything under 1min is ok for a
slow connection i think. It's still a problem we could solve, but at
least it's not at your end, it's in our code.)

@brauliobo
Copy link

@marcelklehr it can take more than one minute, sometimes.

Yeah, even etherpad-lite being a heavy js app that doesn't justify a slow load time. Take google docs as a counter example.

I haven't debugged, but I guess too much requests are being made. Aren't the js being concatenated into one?

@marcelklehr
Copy link
Contributor

nope, they're not ;)

muxator added a commit that referenced this issue Oct 20, 2019
This upgrade should be backward compatible, but still suffers form major
vulnerabilities in its https-proxy-agent transitive dependency (see
https://www.npmjs.com/advisories/1184).

Changelog:
- https://github.com/npm/cli/releases

6.12.0 (2019-10-08):
    Now npm ci runs prepare scripts for git dependencies, and respects the
    --no-optional argument. Warnings for engine mismatches are printed again.
    Various other fixes and cleanups.

    BUG FIXES
    890b245dc #252 ci: add dirPacker to options (@claudiahdz)
    f3299acd0 #257 npm.community#4792 warn message on engine mismatch
                   (@ruyadorno)
    bbc92fb8f #259 npm.community#10288 Fix figgyPudding error in npm token
                   (@benblank)
    70f54dcb5 #241 doctor: Make OK more consistent (@gemal)

    FEATURES
    ed993a29c #249 Add CI environment variables to user-agent (@isaacs)
    f6b0459a4 #248 Add option to save package-lock without formatting Adds a new
                   config --format-package-lock, which defaults to true.
                   (@bl00mber)

DEPENDENCIES
    0ca063c5d [email protected]:
        fix: filter functions and undefined out of makeEnv (@isaacs)
    5df6b0ea2 [email protected]:
        fix: pack git directories properly (@claudiahdz)
        respect no-optional argument (@cruzdanilo)
    7e04f728c [email protected]
    5c380e5a3 [email protected] (@isaacs)
    62f2ca692 [email protected] (@isaacs)
    0ff0ea47a [email protected] (@isaacs)
    f46edae94 [email protected] (@isaacs)

TESTING
    44a2b036b #262 fix root-ownership race conditions in meta-test (@isaacs)

6.11.3 (2019-09-03):
    Fix npm ci regressions and npm outdated depth.

    BUG FIXES
    235ed1d28 #239 Don't override user specified depth in outdated. Restores
                   ability to update packages using --depth as suggested by npm audit. (@G-Rath)
    1fafb5151 #242 npm.community#9586 Revert "install: do not descend into
                   directory deps' child modules" (@isaacs)
    cebf542e6 #243 npm.community#9720 ci: pass appropriate configs for file/dir
                   modes (@isaacs)

    DEPENDENCIES
    e5fbb7ed1 [email protected] (@claudiahdz)
    23ce65616 [email protected] (@claudiahdz)

6.11.2 (2019-08-22):
    Fix a recent Windows regression, and two long-standing Windows bugs. Also,
    get CI running on Windows, so these things are less likely in the future.

    DEPENDENCIES
    9778a1b87 [email protected]: Fix regression where shims fail to preserve exit
              code (@isaacs)
    bf93e91d8 [email protected]: Properly handle git+file: urls on Windows
              when a drive letter is included. (@isaacs)

    BUGFIXES
    6cc4cc66f escape args properly on Windows Bash Despite being bash, Node.js
              running on windows git mingw bash still executes child processes
              using cmd.exe. As a result, arguments in this environment need to
              be escaped in the style of cmd.exe, not bash. (@isaacs)

    TESTS
    291aba7b8 make tests pass on Windows (@isaacs)
    fea3a023a travis: run tests on Windows as well (@isaacs)

6.11.1 (2019-08-20):
    Fix a regression for windows command shim syntax.

    37db29647 [email protected] (@isaacs)

v6.11.0 (2019-08-20):
    A few meaty bugfixes, and introducing peerDependenciesMeta.

    FEATURES
    a12341088 #224 Implements peerDependenciesMeta (@arcanis)
    2f3b79bba #234 add new forbidden 403 error code (@claudiahdz)

    BUGFIXES
    24acc9fc8 and 45772af0d #217 npm.community#8863 npm.community#9327 do not
              descend into directory deps' child modules, fix shrinkwrap files
              that inappropriately list child nodes of symlink packages (@isaacs
              and @salomvary)
    50cfe113d #229 fixed typo in semver doc (@gall0ws)
    e8fb2a1bd #231 Fix spelling mistakes in CHANGELOG-3.md (@XhmikosR)
    769d2e057 npm/uid-number#7 Better error on invalid --user/--group configs.
              This addresses the issue when people fail to install binary
              packages on Docker and other environments where there is no
              'nobody' user. (@isaacs)
    8b43c9624 nodejs/node#28987 npm.community#6032 npm.community#6658
              npm.community#6069 npm.community#9323 Fix the regression where
              random config values in a .npmrc file are not passed to lifecycle
              scripts, breaking build processes which rely on them. (@isaacs)
    8b85eaa47 save files with inferred ownership rather than relying on SUDO_UID
              and SUDO_GID. (@isaacs)
    b7f6e5f02 Infer ownership of shrinkwrap files (@isaacs)
    54b095d77 #235 Add spec to dist-tag remove function (@theberbie)

    DEPENDENCIES
    dc8f9e52f [email protected]: Infer the ownership of all unpacked files in
              node_modules, so that we never have user-owned files in root-owned
              folders, or root-owned files in user-owned folders. (@isaacs)
    bb33940c3 [email protected]:
        9c93ac3 #2 npm#3380 Handle environment variables properly (@basbossink)
        2d277f8 #25 #36 #35 Fix 'no shebang' case by always providing $basedir
                in shell script (@igorklopov)
        adaf20b #26 Fix $* causing an error when arguments contain parentheses
                (@satazor)
        49f0c13 #30 Fix paths for MSYS/MINGW bash (@dscho)
        51a8af3 #34 Add proper support for PowerShell (@ExE-Boss)
        4c37e04 #10 Work around quoted batch file names (@isaacs)
    a4e279544 [email protected] (@isaacs):
        fail properly if uid-number raises an error
    7086a1809 [email protected] (@isaacs)
    8845141f9 [email protected] (@isaacs)
    51c028215 [email protected] (@isaacs)
    534a5548c [email protected] (@isaacs)
    3038f2fd5 [email protected] (@isaacs)
    a609a1648 [email protected] (@isaacs)
    f0346f754 [email protected] (@isaacs)
    ca9c615c8 [email protected] (@isaacs)
    b417affbf [email protected] (@isaacs)

    TESTS
    b6df0913c #228 Proper handing of /usr/bin/node lifecycle-path test (@olivr70)
    aaf98e88c [email protected] (@isaacs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests