-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow loading of pads with many lines when line numbers are enabled #273
Comments
The problem is updateLineNumbers() - "ace2_inner.js:5656". createDocumentFragment give some small improvments to reduce the "reflows" to one.
(see http://code.google.com/intl/de-DE/speed/articles/javascript-dom.html) But the while loop( ... while (a && b) ... ) after, is the main problem. When this will be disabled, the loading is fast again. |
feel free to create a pull request |
Done, i found a way to fix this. Main issue was line "a.style.height = ... ". On first start, every new div of line numbers will be styled. And this is too much for the browser. With documentFragements it works fine. |
Is there a specific reason, why the line numbers will be updated every few seconds, even when nothing was changed? Maybe it wouldbe better, when a state "pad changed" will be set and used to trigger the update function. Btw. etherpad lite is nice. we used it as live editor for javascript files for developing. thats the reason, why we have so much lines :) |
I don't know why the editor is doing that. But thats another issue. I close this one |
This upgrade solves the high-severity vulnerabilities regarding https-proxy-agent that were still present in 8e6bca4. The output of `npm audit` goes from this: found 29 vulnerabilities (3 low, 26 high) in 13338 scanned packages run `npm audit fix` to fix 4 of them. 1 vulnerability requires semver-major dependency updates. 24 vulnerabilities require manual review. See the full report for details. To this: found 5 vulnerabilities (3 low, 2 high) in 13338 scanned packages 1 vulnerability requires semver-major dependency updates. 4 vulnerabilities require manual review. See the full report for details. Changelog: - https://github.com/npm/cli/releases 6.13.1 (2019-11-18) BUG FIXES 938d6124d #472 fix(fund): support funding string shorthand (@ruyadorno) b49c5535b #471 should not publish tap-snapshot folder (@ruyadorno) 3471d5200 #253 Add preliminary WSL support for npm and npx (@infinnie) 3ef295f23 #486 print quick audit report for human output (@isaacs) TESTING dbbf977ac #278 added workflow to trigger and run benchmarks (@mikemimik) b4f5e3825 #457 feat(docs): adding tests and updating docs to reflect changes in registry teams API. (@nomadtechie) 454c7dd60 #456 fix git configs for git 2.23 and above (@isaacs) DEPENDENCIES 661d86cd2 [email protected] (@claudiahdz) 6.13.0 (2019-11-05) NEW FEATURES 4414b06d9 #273 add fund command (@ruyadorno) BUG FIXES e4455409f #281 delete ps1 files on package removal (@NoDocCat) cd14d4701 #279 update supported node list to remove v6.0, v6.1, v9.0 - v9.2 (@ljharb) DEPENDENCIES a37296b20 [email protected] d3cb3abe8 [email protected] TESTING 688cd97be #272 use github actions for CI (@JasonEtco) 9a2d8af84 #240 Clean up some flakiness and inconsistency (@isaacs)
It seems it takes a lot of time to open a pad with many lines(>6000), when line numbering is enabled.
The text was updated successfully, but these errors were encountered: