Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Oct 9, 2025

The go versions in go.mod, go.work files are mismatched and causing the validation run in antithesis #20781 to fail (see here). Not sure if this is the right fix, but would love to hear your thoughts @joshjms @ivanvc.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nwnt
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@nwnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify 268a3d4 link true /test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.15%. Comparing base (116caca) to head (268a3d4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20782      +/-   ##
==========================================
- Coverage   69.20%   69.15%   -0.06%     
==========================================
  Files         422      422              
  Lines       34821    34821              
==========================================
- Hits        24099    24080      -19     
- Misses       9328     9344      +16     
- Partials     1394     1397       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116caca...268a3d4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ivanvc
Copy link
Member

ivanvc commented Oct 9, 2025

I'm trying to understand why make build is breaking in that pull request. We have the pull-etcd-build tests and pull-etcd-release-tests that check this.

The go directive and the toolchain directive don't necessarily need to match. x-ref: #19423 (review).

@ivanvc
Copy link
Member

ivanvc commented Oct 9, 2025

Highly likely is this line:

RUN for d in server etcdutl etcdctl; do (cd ${d} && go mod tidy || true); done

There may be one dependency that it injects that requires 1.25.1.

@ivanvc
Copy link
Member

ivanvc commented Oct 9, 2025

The problem is with the Go environment variables in the Docker image. When the Antithesis code creates the new go.mod, it uses the GOVERSION and GOTOOLCHAIN environment variables. I have a fix for this, but it's not nice. I'll open a PR.

@nwnt
Copy link
Member Author

nwnt commented Oct 9, 2025

Thanks @ivanvc! Will drop this one as yours has been merged

@nwnt nwnt closed this Oct 9, 2025
@nwnt nwnt deleted the update-gomod-1.25.1 branch October 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants