-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[Antithesis] Rename DATA_PATH as prefix #20781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Antithesis] Rename DATA_PATH as prefix #20781
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #20781 +/- ##
==========================================
- Coverage 69.20% 69.11% -0.10%
==========================================
Files 422 422
Lines 34821 34821
==========================================
- Hits 24099 24067 -32
- Misses 9325 9354 +29
- Partials 1397 1400 +3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
The verification fails due to mismatched go versions in go.mod and go.work. See the above PR. |
| # With root owner, accessing the WAL files from local tests will fail due to an unauthorized access error. | ||
| init: | ||
| image: 'docker.io/library/ubuntu:latest' | ||
| image: "docker.io/library/ubuntu:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid such changes mixed into unrelated PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't see these and was focusing on what broke the changes. These came from the auto linters I have, but all are reverted.
|
/retest |
e02fd67 to
43fe3a4
Compare
Signed-off-by: Nont <[email protected]>
43fe3a4 to
aac05ad
Compare
|
@nwnt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As discussed in the community call, I'm breaking the previous PR down to smaller steps. This is the first of the series.
@serathius