Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Oct 9, 2025

As discussed in the community call, I'm breaking the previous PR down to smaller steps. This is the first of the series.

@serathius

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.11%. Comparing base (2261dfb) to head (aac05ad).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20781      +/-   ##
==========================================
- Coverage   69.20%   69.11%   -0.10%     
==========================================
  Files         422      422              
  Lines       34821    34821              
==========================================
- Hits        24099    24067      -32     
- Misses       9325     9354      +29     
- Partials     1397     1400       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2261dfb...aac05ad. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwnt
Copy link
Member Author

nwnt commented Oct 9, 2025

The verification fails due to mismatched go versions in go.mod and go.work. See the above PR.

# With root owner, accessing the WAL files from local tests will fail due to an unauthorized access error.
init:
image: 'docker.io/library/ubuntu:latest'
image: "docker.io/library/ubuntu:latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid such changes mixed into unrelated PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't see these and was focusing on what broke the changes. These came from the auto linters I have, but all are reverted.

@serathius
Copy link
Member

/retest

@nwnt nwnt force-pushed the refactor-antithesis-env-data-paths branch from e02fd67 to 43fe3a4 Compare October 9, 2025 13:46
@nwnt nwnt force-pushed the refactor-antithesis-env-data-paths branch from 43fe3a4 to aac05ad Compare October 9, 2025 13:48
@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Oct 9, 2025
@k8s-ci-robot
Copy link

@nwnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-arm64 aac05ad link true /test pull-etcd-unit-test-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius serathius merged commit 81ed8ee into etcd-io:main Oct 9, 2025
32 of 33 checks passed
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants