Skip to content

adt: update docstrings for IntervalTree.Insert and IntervalTree.find#20015

Merged
ahrtr merged 1 commit intoetcd-io:mainfrom
redwrasse:redwrasse/update-docs-ivt-splits
May 23, 2025
Merged

adt: update docstrings for IntervalTree.Insert and IntervalTree.find#20015
ahrtr merged 1 commit intoetcd-io:mainfrom
redwrasse:redwrasse/update-docs-ivt-splits

Conversation

@redwrasse
Copy link
Contributor

Follow up to #19768, updating function docstrings for interval tree Insert and find operations (#19768 (comment)).

cc @serathius @ahrtr , let me know if this is what you had in mind.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @redwrasse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented May 23, 2025

Please squash the commits and signoff it. thx

    to reflect modified algorithms.

Signed-off-by: redwrasse <mail@redwrasse.io>
@redwrasse redwrasse force-pushed the redwrasse/update-docs-ivt-splits branch from 16cf8b9 to c604bfd Compare May 23, 2025 16:57
@redwrasse
Copy link
Contributor Author

Please squash the commits and signoff it. thx

Squashed and signed.

@ahrtr
Copy link
Member

ahrtr commented May 23, 2025

/ok-to-test

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.87%. Comparing base (0167cb3) to head (c604bfd).
Report is 14 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
pkg/adt/interval_tree.go 88.78% <ø> (ø)

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20015      +/-   ##
==========================================
+ Coverage   68.76%   68.87%   +0.11%     
==========================================
  Files         424      424              
  Lines       35764    35762       -2     
==========================================
+ Hits        24592    24630      +38     
+ Misses       9748     9719      -29     
+ Partials     1424     1413      -11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0167cb3...c604bfd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thx

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, redwrasse, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit ebcfdd0 into etcd-io:main May 23, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants