Skip to content

[Antithesis] Fix lint and rename Dockerfile #19820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serathius merged 1 commit into from
Apr 29, 2025
Merged

[Antithesis] Fix lint and rename Dockerfile #19820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/antithesis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This directory enables integration of Antithesis with etcd. There are 4 containe
Run this command from the `antithesis/test-template` directory:

```bash
docker build . -f Dockerfile.client -t etcd-client:latest
docker build . -f Dockerfile -t etcd-client:latest
Copy link
Member

@serathius serathius Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing change in .github/workflows/antithesis-test.yml but let's merge it as it's not breaking anyone.

```

### 2. (Optional) Check the Image Locally
Expand Down
0 ...ntithesis/test-template/Dockerfile.client → tests/antithesis/test-template/Dockerfile
View file
Open in desktop
File renamed without changes.
18 changes: 17 additions & 1 deletion tests/antithesis/test-template/entrypoint/entrypoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
// Copyright 2025 The etcd Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build cgo && amd64

package main

import (
Expand All @@ -13,7 +29,7 @@ import (
// Sleep duration
const SLEEP = 10

// check health of all etcd nodes
// CheckHealth checks health of all etcd nodes
func CheckHealth() bool {
nodeOptions := []string{"etcd0", "etcd1", "etcd2"}

Expand Down
19 changes: 18 additions & 1 deletion tests/antithesis/test-template/go-delete-keys/serial_driver_delete_keys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
// Copyright 2025 The etcd Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build cgo && amd64

package main

import (
Expand Down Expand Up @@ -102,4 +118,5 @@ func DeleteKeys() {

func main() {
DeleteKeys()
}
}