[Antithesis] Fix lint and rename Dockerfile#19820
Conversation
|
Hi @nwnt. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Nont <nont@duck.com>
462b624 to
c3d7b2a
Compare
|
/retest |
|
@nwnt: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| ```bash | ||
| docker build . -f Dockerfile.client -t etcd-client:latest | ||
| docker build . -f Dockerfile -t etcd-client:latest |
There was a problem hiding this comment.
This is missing change in .github/workflows/antithesis-test.yml but let's merge it as it's not breaking anyone.
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 49 files with indirect coverage changes @@ Coverage Diff @@
## main #19820 +/- ##
========================================
Coverage 67.60% 67.60%
========================================
Files 421 406 -15
Lines 35863 35437 -426
========================================
- Hits 24244 23958 -286
+ Misses 10193 10050 -143
- Partials 1426 1429 +3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Separating the changes required for #19797. This aims to fix all the linting issues. It also renames the dockerfile from Dockerfile.client to Dockerfile.