Skip to content

[Antithesis] Fix lint and rename Dockerfile#19820

Merged
serathius merged 1 commit intoetcd-io:mainfrom
nwnt:nwnt/fix-lint-and-rename-antithesis
Apr 29, 2025
Merged

[Antithesis] Fix lint and rename Dockerfile#19820
serathius merged 1 commit intoetcd-io:mainfrom
nwnt:nwnt/fix-lint-and-rename-antithesis

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Apr 29, 2025

Separating the changes required for #19797. This aims to fix all the linting issues. It also renames the dockerfile from Dockerfile.client to Dockerfile.

@k8s-ci-robot
Copy link

Hi @nwnt. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Nont <nont@duck.com>
@nwnt nwnt force-pushed the nwnt/fix-lint-and-rename-antithesis branch from 462b624 to c3d7b2a Compare April 29, 2025 02:37
@nwnt
Copy link
Member Author

nwnt commented Apr 29, 2025

/retest

@k8s-ci-robot
Copy link

@nwnt: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


```bash
docker build . -f Dockerfile.client -t etcd-client:latest
docker build . -f Dockerfile -t etcd-client:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing change in .github/workflows/antithesis-test.yml but let's merge it as it's not breaking anyone.

@serathius
Copy link
Member

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (799f07b) to head (c3d7b2a).
Report is 5 commits behind head on main.

Additional details and impacted files

see 49 files with indirect coverage changes

@@           Coverage Diff            @@
##             main   #19820    +/-   ##
========================================
  Coverage   67.60%   67.60%            
========================================
  Files         421      406    -15     
  Lines       35863    35437   -426     
========================================
- Hits        24244    23958   -286     
+ Misses      10193    10050   -143     
- Partials     1426     1429     +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bbb46...c3d7b2a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius serathius merged commit 8ca65f5 into etcd-io:main Apr 29, 2025
29 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants