tools/benchmark/README.md: Update installation as go get does not work#13027
Merged
ptabor merged 1 commit intoetcd-io:mainfrom May 31, 2021
Merged
tools/benchmark/README.md: Update installation as go get does not work#13027ptabor merged 1 commit intoetcd-io:mainfrom
ptabor merged 1 commit intoetcd-io:mainfrom
Conversation
ptabor
reviewed
May 23, 2021
Contributor
Also seems to install the tool (please notice the /v3) |
Contributor
Author
|
You know I tried various different go get combos with v3 but not this one :D Thank you @ptabor, please have another look! |
ptabor
approved these changes
May 31, 2021
Contributor
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a lot of users mentioning
go get go.etcd.io/etcd/tools/benchmarkdoes not work for thebenchmarktool. This updates the instructions to avoid confusion. I am not sure if the goal is to get it to work withgo get, but I would suggest we open a follow-up issue if we want to.Fixes #12526 #12851