Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wal: fix panic when decoder not set #12639

Merged
merged 1 commit into from
Jan 21, 2021
Merged

wal: fix panic when decoder not set #12639

merged 1 commit into from
Jan 21, 2021

Conversation

retroflexer
Copy link

Manual cherry-pick of #11807 (cherry picked as #12087 in 3.3)

@spzala
wal: fix panic when decoder not set
8d4ab97 
Handle the related panic and clarify doc.
hexfusion
hexfusion approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hexfusion hexfusion merged commit 7a07e9f into etcd-io:release-3.2 Jan 21, 2021
@retroflexer retroflexer deleted the check-nil-decoder branch January 21, 2021 18:50
@retroflexer retroflexer mentioned this pull request Jan 21, 2021
Merged
@retroflexer retroflexer mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexfusion hexfusion hexfusion approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@retroflexer @hexfusion @spzala