[release-1.3] chore(CI): add golangci linter rules

[Elbehery]

backport of #993

cc @ahrtr @ivanvc

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Elbehery]

/retest

[Elbehery]

@ivanvc can u help with this failure ?

It works on main branch !!!

[Elbehery]

/retest

[ivanvc]

@ivanvc can u help with this failure ?

It works on main branch !!!

The main branch uses Go 1.24, while the release branches use 1.23. I'm unsure if golangci-lint works well with Go 1.23.

[Elbehery]

@ivanvc can u help with this failure ?
It works on main branch !!!

The main branch uses Go 1.24, while the release branches use 1.23. I'm unsure if golangci-lint works well with Go 1.23.

well the failure in Win env only :D

[ivanvc]

well the failure in Win env only :D

I don't think we want to merge a pull request if it will break the CI. Would it be possible to use golangci-lint v1, with the rules you enabled, rather than bumping the version to 2?

[Elbehery]

well the failure in Win env only :D

I don't think we want to merge a pull request if it will break the CI. Would it be possible to use golangci-lint v1, with the rules you enabled, rather than bumping the version to 2?

unfortunately no, these rules require v2 😞

but if we were to maintain the same linting across release branches, how would we proceed ?

cc @ahrtr

[ahrtr]

We don't see any issue on main branch. Probably it's due to different golang version?

Eventually we will bump to v2, but for now let's do not get stuck here (I don't mind closing this PR for now), we should always keep the workflow green.

[Elbehery]

lgtm 👍🏽

[ivanvc]

@Elbehery, I believe now this is possible due to #1071

[Elbehery]

alright, let me reopen, delete the branch .

hold on 👍🏽